Message187169
Personally I prefer having the test create the needed test file, rather than adding a new file to the repository, for small files. That's just my opinion, though; as you found what you did is common practice currently. Your patch doesn't include the file, though.
(I haven't reviewed the rest of the patch.) |
|
| Date |
User |
Action |
Args |
| 2013-04-17 14:57:16 | r.david.murray | set | recipients:
+ r.david.murray, ncoghlan, pitrou, kyle.roberts |
| 2013-04-17 14:57:16 | r.david.murray | set | messageid: <1366210636.32.0.853937355267.issue17673@psf.upfronthosting.co.za> |
| 2013-04-17 14:57:16 | r.david.murray | link | issue17673 messages |
| 2013-04-17 14:57:16 | r.david.murray | create | |
|