Message 187188 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	kyle.roberts, ncoghlan, pitrou, r.david.murray
Date	2013-04-17.18:25:17
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1366223117.2.0.0751497316272.issue17673@psf.upfronthosting.co.za>
In-reply-to

Content
Some comments about the patch: - unless I'm missing something, I think you should re-use the fd instead of reopening the file by name - it would be nice if copy_from accepted an open file-like object, e.g. a BytesIO instance - I don't think you need a specific file for the test; just use an existing one (e.g. __file__, or one of the data files somewhere in the test subtree) - the doc needs some "versionchanged" markers

Some comments about the patch:
- unless I'm missing something, I think you should re-use the fd instead of reopening the file by name
- it would be nice if copy_from accepted an open file-like object, e.g. a BytesIO instance
- I don't think you need a specific file for the test; just use an existing one (e.g. __file__, or one of the data files somewhere in the test subtree)
- the doc needs some "versionchanged" markers

History
Date	User	Action	Args
2013-04-17 18:25:17	pitrou	set	recipients: + pitrou, ncoghlan, r.david.murray, kyle.roberts
2013-04-17 18:25:17	pitrou	set	messageid: <1366223117.2.0.0751497316272.issue17673@psf.upfronthosting.co.za>
2013-04-17 18:25:17	pitrou	link	issue17673 messages
2013-04-17 18:25:17	pitrou	create