Skip to content

feat: Implement DoRA - #1150

Merged
akoumpa merged 5 commits into
NVIDIA-NeMo:mainfrom
therealnaveenkamal:dora
Feb 7, 2026
Merged

feat: Implement DoRA#1150
akoumpa merged 5 commits into
NVIDIA-NeMo:mainfrom
therealnaveenkamal:dora

Conversation

@therealnaveenkamal

@therealnaveenkamal therealnaveenkamal commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do ?

Implements DoRA.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

@therealnaveenkamal
Implements DoRA
7df1590 
Signed-off-by: Naveenraj Kamalakannan <therealnaveenkamal@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Feb 2, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

akoumpa
akoumpa reviewed Feb 2, 2026
View reviewed changes
Comment thread tests/functional_tests/checkpoint/test_peft.py
@akoumpa

akoumpa commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

/ok to test 7df1590

@therealnaveenkamal
added test_hf_peft_dora_checkpoint
be57454 
Signed-off-by: Naveenraj Kamalakannan <therealnaveenkamal@gmail.com>
@akoumpa

akoumpa commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

/ok to test be57454

@therealnaveenkamal
added cli args to conftest
378d682 
Signed-off-by: Naveenraj Kamalakannan <therealnaveenkamal@gmail.com>
@akoumpa

akoumpa commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

/ok to test 378d682

@therealnaveenkamal
name fix
baa67b9 
Signed-off-by: Naveenraj Kamalakannan <therealnaveenkamal@gmail.com>
@therealnaveenkamal

therealnaveenkamal commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

@akoumpa the L2_HF_PEFT_DoRA_FSDP2_Checkpoint test now passes locally.

@akoumpa

akoumpa commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

/ok to test baa67b9

This branch was previously deployed

2 inactive deployments
nemo-ci — baa67b96 Deployed Feb 7, 2026 by copy-pr-bot[bot] via L2_Datasets #3575
test — baa67b96 Deployed Feb 7, 2026 by copy-pr-bot[bot] via cicd-wait-in-queue #3575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoumpa akoumpa akoumpa approved these changes
@HuiyingLi HuiyingLi Awaiting requested review from HuiyingLi
@adil-a adil-a Awaiting requested review from adil-a
@hemildesai hemildesai Awaiting requested review from hemildesai

Assignees

No one assigned

Labels

community-request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can you support DoRA?

3 participants

@therealnaveenkamal @akoumpa @chtruong814