Skip to content

feat: port ministral3 to transformers v4 - #934

Merged
thomasdhc merged 10 commits into
mainfrom
huiyingl/port_ministral3
Dec 8, 2025
Merged

feat: port ministral3 to transformers v4#934
thomasdhc merged 10 commits into
mainfrom
huiyingl/port_ministral3

Conversation

@HuiyingLi

@HuiyingLi HuiyingLi commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@HuiyingLi
port ministral3 as custom model
7128db6 
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
@copy-pr-bot

copy-pr-bot Bot commented Dec 5, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@HuiyingLi
update copyright
9b4908c 
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
@HuiyingLi
add test
79bcea4 
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
@akoumpa

akoumpa commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

/ok to test 79bcea4

@akoumpa
lint fix
7a676f9 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa

akoumpa commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

/ok to test 7a676f9

@akoumpa
lint fix
acd0df2 
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa

akoumpa commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

/ok to test acd0df2

akoumpa
akoumpa previously approved these changes Dec 5, 2025
View reviewed changes
@akoumpa
akoumpa enabled auto-merge (squash) December 5, 2025 19:53
@HuiyingLi
Merge branch 'main' into huiyingl/port_ministral3
149e71b
@HuiyingLi
add llm path
f847284 
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
@HuiyingLi
update tests
57327ba 
Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
@HuiyingLi

HuiyingLi commented Dec 5, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 57327ba

This branch was previously deployed

2 inactive deployments
nemo-ci — 57327ba1 Deployed Dec 6, 2025 by copy-pr-bot[bot] via L2_clip_grad_norm #2821
test — 57327ba1 Deployed Dec 5, 2025 by copy-pr-bot[bot] via cicd-wait-in-queue #2821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoumpa akoumpa akoumpa approved these changes
@adil-a adil-a Awaiting requested review from adil-a
@hemildesai hemildesai Awaiting requested review from hemildesai
+1 more reviewer
@thomasdhc thomasdhc thomasdhc approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

r0.2.0 Add for cherry-pick into release branch 0.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HuiyingLi @akoumpa @thomasdhc