Repository navigation
fs/remote: Refactor blob code to make it more modular - #1948
Closed
ChengyuZhu6 wants to merge 1 commit into
Closed
ChengyuZhu6 wants to merge 1 commit into
ChengyuZhu6 wants to merge 1 commit into
Conversation
ktock
reviewed
Jan 20, 2025
ktock
reviewed
Jan 21, 2025
ChengyuZhu6
force-pushed
the
refactor
branch
2 times, most recently
from
January 21, 2025 07:23
ba7f88a to
e519d34
Compare
Member
Author
|
retrigger the ci |
ktock
reviewed
Jan 21, 2025
ChengyuZhu6
force-pushed
the
refactor
branch
2 times, most recently
from
January 22, 2025 01:54
22d567c to
498f2a5
Compare
Member
Author
|
just retrigger the ci |
ktock
reviewed
Jan 22, 2025
ChengyuZhu6
force-pushed
the
refactor
branch
4 times, most recently
from
January 22, 2025 05:49
b3a4e9b to
1cac7e0
Compare
ktock
reviewed
Jan 23, 2025
| defer r.Close() | ||
| var n int | ||
| n, err = r.ReadAt(dest, offset) | ||
| if (err == nil || err == io.EOF) && int64(n) == int64(len(dest)) { |
Member
There was a problem hiding this comment.
assign an explicit error on err == nil but int64(n) != int64(len(dest)) otherwize nil error will returned to the caller in that case.
ChengyuZhu6
force-pushed
the
refactor
branch
2 times, most recently
from
January 24, 2025 01:35
e81687d to
7610466
Compare
This commit refactors the blob handling code to improve code organization. The changes include: 1. Extract chunk handling logic into separate functions: - prepareChunksForRead: Prepare chunks for reading - readFromCache: Handle cache reading - cacheChunkData: Handle chunk caching - handleSharedFetch: Handle shared fetch scenarios - copyFetchedChunks: Copy fetched chunks 2. Improve error handling: - Add more descriptive error messages - Consistent error wrapping using fmt.Errorf - Maintain same error handling behavior 3. Keep original behavior: - Maintain same data flow - Keep same concurrency control - No additional memory allocations - Same caching mechanism 4. Code organization improvements: - Single responsibility functions - Clear function names - Better code readability - Easier to maintain and test Signed-off-by: ChengyuZhu6 <hudson@cyzhu.com>
Member
Author
|
Just retrigger the ci |
Member
|
Thanks, I'll merge this via #1955. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the blob handling code to improve code organization. The changes include:
Extract chunk handling logic into separate functions:
Improve error handling:
Keep original behavior:
Code organization improvements: