Skip to content

Add JPP flag OPENJDK_METHODHANDLES to match OpenJDK content - #13397

Closed
JasonFengJ9 wants to merge 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:jdk18staging
Closed

JasonFengJ9 wants to merge 1 commit into
eclipse-openj9:masterfrom
JasonFengJ9:jdk18staging

Conversation

@JasonFengJ9

Copy link
Copy Markdown
Member

OPENJDK_METHODHANDLES is enabled in JDK18 extension repo openj9-staging branch which has latest OpenJDK content but not promoted into openj9 branch yet;
Added this JPP flag to ensure OpenJ9 methods marked as Deprecated matching those OpenJDK references.

This fixes PR build failure #13395 (comment)

Signed-off-by: Jason Feng fengj@ca.ibm.com

OPENJDK_METHODHANDLES is enabled in JDK18 extension repo openj9-staging
branch which has latest OpenJDK content but not promoted into openj9
branch yet;
Added this JPP flag to ensure OpenJ9 methods marked as Deprecated
matching those OpenJDK references.

Signed-off-by: Jason Feng <fengj@ca.ibm.com>
@tajila

tajila commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

I think we should promote the openj9-staging branch in jdknext

@tajila

tajila commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

The recent test results look good for JDKNext, https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK-Acceptance/

What do we need to do to promote the staging branch?

@JasonFengJ9

Copy link
Copy Markdown
Member Author

What do we need to do to promote the staging branch?

Latest jdkNext abuild[1] is green, maybe the promotion is disabled.

fyi @pshipton

[1] https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK-Acceptance/87/

@pshipton

pshipton commented Sep 8, 2021 •

Copy link
Copy Markdown
Member

I've promoted the last building level, and enabled promotion in future builds. We have no promotion criteria other than successfully building atm as the sanity.functional tests don't pass, however I agree it's better to test the latest.

@pshipton pshipton closed this Sep 8, 2021
@JasonFengJ9
JasonFengJ9 deleted the jdk18staging branch September 8, 2021 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants