Repository navigation
Add JPP flag OPENJDK_METHODHANDLES to match OpenJDK content - #13397
Closed
JasonFengJ9 wants to merge 1 commit into
Closed
JasonFengJ9 wants to merge 1 commit into
JasonFengJ9 wants to merge 1 commit into
Conversation
OPENJDK_METHODHANDLES is enabled in JDK18 extension repo openj9-staging branch which has latest OpenJDK content but not promoted into openj9 branch yet; Added this JPP flag to ensure OpenJ9 methods marked as Deprecated matching those OpenJDK references. Signed-off-by: Jason Feng <fengj@ca.ibm.com>
tajila
approved these changes
Sep 8, 2021
Contributor
|
I think we should promote the openj9-staging branch in jdknext |
Contributor
|
The recent test results look good for JDKNext, https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK-Acceptance/ What do we need to do to promote the staging branch? |
Member
Author
Latest jdkNext abuild[1] is green, maybe the promotion is disabled. fyi @pshipton [1] https://openj9-jenkins.osuosl.org/job/Pipeline-OpenJDK-Acceptance/87/ |
Member
|
I've promoted the last building level, and enabled promotion in future builds. We have no promotion criteria other than successfully building atm as the sanity.functional tests don't pass, however I agree it's better to test the latest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OPENJDK_METHODHANDLESis enabled inJDK18extension repoopenj9-stagingbranch which has latest OpenJDK content but not promoted intoopenj9branch yet;Added this JPP flag to ensure OpenJ9 methods marked as
Deprecatedmatching those OpenJDK references.This fixes PR build failure #13395 (comment)
Signed-off-by: Jason Feng fengj@ca.ibm.com