Repository navigation
Adding libs for OpenXL - #20045
Adding libs for OpenXL#20045ishitaR88 wants to merge 6 commits into
Conversation
|
Two high-level comments:
|
|
please indicate if it cleared the criteria that, with these changes in place, we can build with both xlC/xlclang and OpenXL (also staying or better the performance). that is when it is ready to be reviewed. |
|
did I miss your changes to makefiles, to set CC and CXX? at least, i haven't seen them yet. |
|
I tried a build with the OMR (eclipse-omr/omr#7447) and these OpenJ9 changes. It got this far: |
defaults.yml should be updated similarly to https://github.ibm.com/Peter-Shipton/tooling/commit/eebd2986b8a3b It won't work on any OpenJ9 open machine until we update them to have the 17.1.2 compiler. |
Yes there was an issue. I have fixed that.will push the modification shortly. |
There was a problem hiding this comment.
This can't be changed unconditionally.
FYI module.xml (UMA) is mostly used for IBM Java 8 builds, but it's still (was) possible use UMA to build OpenJ9 versions, It's something we should check, if UMA is still working for Java 23 with OpenXL. By default we use cmake, but UMA can be used if adding options for debugging purposes.
e426cf2 to
121bd27
Compare
There was a problem hiding this comment.
The subexpression defined(__cplusplus) seems redundant in this C++ source file.
There was a problem hiding this comment.
Fixed it in new commit
There was a problem hiding this comment.
Please invert and add equivalent options for OpenXL.
|
Tried a new build https://hyc-runtimes-jenkins.swg-devops.com/job/Build_JDK23_ppc64_aix_Personal/52 |
0a882d4 to
60ce5cd
Compare
There was a problem hiding this comment.
This file needs a copyright notice.
There was a problem hiding this comment.
The current year should be used in the copyright notice for new files.
There was a problem hiding this comment.
Changed year to 2024
9ddb7f3 to
795bb55
Compare
There was a problem hiding this comment.
this looks weird, given the fact that && has higher precedence over ||. it seems dangerous or unreadable to mix up compiler macro (__open_xl__) with platform macro (J9ZOS390 and LINUXPPC64).
There was a problem hiding this comment.
There was a problem hiding this comment.
I agree, it should be __MVS__ and with the fix Julian suggests.
There was a problem hiding this comment.
As the MVS issue is not introduced by the changes of this PR I will address this in future creating a new PR.
There was a problem hiding this comment.
wondering why we need to do this to begin with. WIN32 definition already excludes the code from being picked up on AIX or zOS, what is the purpose of && with more other conditions?
There was a problem hiding this comment.
for the above dozen ffi.h files on non-AIX platforms, do we really need to change this line of code, especially since it is under# ifdef _AIX to begin with. in other words, how changing or not-changing this code affect the builds on non-AIX platforms?
There was a problem hiding this comment.
take notice maybe: we need to revisit this flag setting in the future ... -qarch=ppc is pretty out of date and conservative.
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: midronij <jackie.midroni@ibm.com>
Signed-off-by: Ishita Ray <ishita.ray@ibm.com>
Add CMAKE_C_COMPILER_IS_OPENXL macro to add the compiler flags needed by openXL17 Signed-off-by: Ishita Ray <ishita.ray@ibm.com>
There was a problem hiding this comment.
This would require parentheses if __cplusplus needed to be tested, but it doesn't:
#if defined(__IBMC__) || defined(__open_xl__)
The condition should be repeated (in a comment) on #else and #endif lines.
|
|
||
| #ifdef WIN32 | ||
| #ifdef __IBMC__ | ||
| #if defined(__IBMC__) || defined(__open_xl__) && !defined(__cplusplus) |
There was a problem hiding this comment.
Please remove redundant uses of defined(__cplusplus) throughout.
| # ifdef _AIX /* AIX 5.1 and earlier have LONGLONG_MAX */ | ||
| # ifndef __PPC64__ | ||
| # if defined (__IBMC__) || defined (__IBMCPP__) | ||
| # if defined (__IBMC__) || defined (__IBMCPP__) || defined(__open_xl__) |
There was a problem hiding this comment.
Please revert changes such as this (where Open XL can't apply).
| else | ||
| # xlc++ options | ||
| CXXFLAGS += -q mbcs -qinfo=pro | ||
| else |
There was a problem hiding this comment.
This is not legal (only one else is allowed).
| if(DEFINED OMR_OS_AIX AND DEFINED CMAKE_C_COMPILER_IS_OPENXL) | ||
| target_link_libraries(j9vrb | ||
| PRIVATE |
There was a problem hiding this comment.
Please don't do this. If libraries are need by any compiler, they should be used for all.
|
The description is incomplete. This isn't just about libraries - many command-line options are adjusted and source is changed. Please follow the commit guidelines at https://github.com/eclipse-omr/omr/blob/master/CONTRIBUTING.md#commit-guidelines (the commit summary and the headline here should be "written in the imperative mood"). |
No description provided.