Skip to content

Relocate Value Propagation analysis of ArrayStoreCHK and arraylength - #6323

Merged
0xdaryl merged 1 commit into
eclipse-omr:masterfrom
hzongaro:refactor-arraylength-arraystorechk-vp-analysis
Feb 23, 2022
Merged

0xdaryl merged 1 commit into
eclipse-omr:masterfrom
hzongaro:refactor-arraylength-arraystorechk-vp-analysis

Conversation

@hzongaro

@hzongaro hzongaro commented Feb 1, 2022 •

Copy link
Copy Markdown
Contributor

Move some analysis of ArrayStoreCHK and arraylength operations out of VPHandlers.cpp so they can be shared with other parts of Value Propagation, particularly in downstream projects.

Some OpenJ9-specific code in constrainArrayLength in VPHandlers.cpp will be removed in a follow up pull request after it is transferred to that downstream project.

This is the first planned pull request mentioned in OpenJ9 issue #14402

@hzongaro

hzongaro commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

Marking this as draft while some tests are running

@hzongaro
hzongaro force-pushed the refactor-arraylength-arraystorechk-vp-analysis branch from 963e2ba to d95d971 Compare February 1, 2022 18:39
@hzongaro
hzongaro marked this pull request as ready for review February 3, 2022 14:44
@hzongaro
hzongaro requested a review from a7ehuo February 3, 2022 14:44
@hzongaro

hzongaro commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

Vijay @vijaysun-omr, Annabelle @a7ehuo, may I ask you to review this change? It should be considered in conjunction with OpenJ9 pull request #14411.

@a7ehuo a7ehuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor comments

Comment thread compiler/optimizer/VPHandlers.cpp Resolved
Comment thread compiler/optimizer/VPHandlers.cpp Resolved
Comment thread compiler/optimizer/VPHandlers.cpp Resolved
Comment thread compiler/optimizer/VPHandlers.cpp Resolved
@hzongaro

hzongaro commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing, Annabelle @a7ehuo! It's ready for a re-review.

I can squash the most recent commits once all reviews have been completed.

Comment thread compiler/optimizer/VPHandlers.cpp Resolved
Comment thread compiler/optimizer/VPHandlers.cpp Resolved
@vijaysun-omr

Copy link
Copy Markdown
Contributor

I have approved this after the changes you made. Once Daryl's given his okay for this, one of us can merge it (assuming tests pass).

Move some analysis of ArrayStoreCHK and arraylength operations out of
VPHandlers.cpp so they can be shared with other parts of Value
Propagation, particularly in downstream projects.

Some OpenJ9-specific code in constrainArrayLength in VPHandlers.cpp will
be removed after it is transferred to that downstream project.
@hzongaro
hzongaro force-pushed the refactor-arraylength-arraystorechk-vp-analysis branch from 73132f8 to bdfec94 Compare February 10, 2022 21:17
@hzongaro

Copy link
Copy Markdown
Contributor Author

Squashed commits into commit bdfec94

@hzongaro

Copy link
Copy Markdown
Contributor Author

Jenkins build all

@hzongaro

Copy link
Copy Markdown
Contributor Author

I have approved this after the changes you made. Once Daryl's given his okay for this, one of us can merge it (assuming tests pass).

Daryl @0xdaryl, have you had an opportunity to look at this?

@0xdaryl 0xdaryl self-assigned this Feb 23, 2022
@0xdaryl
0xdaryl merged commit 5717ad1 into eclipse-omr:master Feb 23, 2022
@hzongaro
hzongaro deleted the refactor-arraylength-arraystorechk-vp-analysis branch March 8, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants