Skip to content

Add Compose initializer for multiple config sources - #3485

Merged
omry merged 1 commit into
mainfrom
pr3485
Sep 28, 2026
Merged

omry merged 1 commit into
mainfrom
pr3485

Conversation

@omry

@omry omry commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Expose an ordered URI-based Compose initializer so external configs can reference packaged defaults. Document its validation and lifecycle behavior, and test source precedence and context restoration.

Refs #3230.

Comment thread hydra/initialize.py Fixed
@omry

omry commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

Might be able to express the other initializes in terms of this new generic one.

@omry

omry commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:9cf2709ea7f496e9bc6870aa7f9bcba0ae87020f91d0fef0451e1f92d754e49d",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:9cf2709ea7f496e9bc6870aa7f9bcba0ae87020f91d0fef0451e1f92d754e49d",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "build"
        },
        {
          "conclusion": "SUCCESS",
          "name": "lint"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.10)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.11)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.12)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.13)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.14)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.10)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.11)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.12)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.13)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.14)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.10)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.11)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.12)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.13)"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.14)"
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:1df56799af92798e40ad81545fddcda558a1dc8f2050e25651f0c8d5fe8301fa",
      "operation_identity": "sha256:f739dc4b7ca86e033443569bba5dbf7bc7b6d395120e891183794acf61ced262",
      "review_request": {
        "body_digest": "sha256:442cdad3724a026cc059508fb836e671b9ca672e75b349258c85d6f65de647ed",
        "id": 5878253768
      },
      "review_result": {
        "body_digest": "sha256:67747db7a062160ab2fd8ec7a63bd1e25f5ed0bd644b377643ce7a5131304b3d",
        "id": 5878307796
      }
    },
    "evidence_fingerprint": "sha256:4a89c1928cf73f2477b4e685fe7d4e879bcedde0dd1e6cbde6464718eba3ffbb",
    "head_sha": "a5bad00b598ad91a5220838196b74f6575767db3",
    "operation_identity": "sha256:f739dc4b7ca86e033443569bba5dbf7bc7b6d395120e891183794acf61ced262",
    "review_request_id": 5878253768,
    "review_result_id": 5878307796,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:9cf2709ea7f496e9bc6870aa7f9bcba0ae87020f91d0fef0451e1f92d754e49d",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "build"
    },
    {
      "conclusion": "SUCCESS",
      "name": "lint"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_linux (3.10)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_linux (3.11)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_linux (3.12)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_linux (3.13)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_linux (3.14)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_macos (3.10)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_macos (3.11)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_macos (3.12)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_macos (3.13)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_macos (3.14)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_win (3.10)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_win (3.11)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_win (3.12)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_win (3.13)"
    },
    {
      "conclusion": "SUCCESS",
      "name": "test_win (3.14)"
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "build",
          "run_id": 108846970063,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397410049/job/108846970063"
        },
        {
          "conclusion": "SUCCESS",
          "name": "lint",
          "run_id": 108846969211,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969211"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.10)",
          "run_id": 108846969629,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969629"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.11)",
          "run_id": 108846969567,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969567"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.12)",
          "run_id": 108846969566,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969566"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.13)",
          "run_id": 108846969673,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969673"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.14)",
          "run_id": 108846969605,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969605"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.10)",
          "run_id": 108846969552,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969552"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.11)",
          "run_id": 108846969702,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969702"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.12)",
          "run_id": 108846969684,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969684"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.13)",
          "run_id": 108846969487,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969487"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.14)",
          "run_id": 108846969597,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969597"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.10)",
          "run_id": 108846969652,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969652"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.11)",
          "run_id": 108846969543,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969543"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.12)",
          "run_id": 108846969549,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969549"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.13)",
          "run_id": 108846969604,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969604"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.14)",
          "run_id": 108846969578,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36397409901/job/108846969578"
        }
      ],
      "head_sha": "811ab06014449d6a3d13fe29d0d480857719ead8",
      "id": "sha256:37164a1eb908c74570de1cd99e9015af73efa42472ae0487624358f2aa238a1c",
      "required_checks": [
        "build",
        "lint",
        "test_linux (3.10)",
        "test_linux (3.11)",
        "test_linux (3.12)",
        "test_linux (3.13)",
        "test_linux (3.14)",
        "test_macos (3.10)",
        "test_macos (3.11)",
        "test_macos (3.12)",
        "test_macos (3.13)",
        "test_macos (3.14)",
        "test_win (3.10)",
        "test_win (3.11)",
        "test_win (3.12)",
        "test_win (3.13)",
        "test_win (3.14)"
      ],
      "status": "success"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "build",
          "run_id": 109116102515,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904485/job/109116102515"
        },
        {
          "conclusion": "SUCCESS",
          "name": "lint",
          "run_id": 109116109416,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109416"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.10)",
          "run_id": 109116109682,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109682"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.11)",
          "run_id": 109116109353,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109353"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.12)",
          "run_id": 109116109962,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109962"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.13)",
          "run_id": 109116109393,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109393"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.14)",
          "run_id": 109116109691,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109691"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.10)",
          "run_id": 109116109766,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109766"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.11)",
          "run_id": 109116109592,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109592"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.12)",
          "run_id": 109116109574,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109574"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.13)",
          "run_id": 109116109627,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109627"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.14)",
          "run_id": 109116109583,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109583"
        },
        {
          "conclusion": "CANCELLED",
          "name": "test_win (3.10)",
          "run_id": 109116109641,
          "run_status": "completed",
          "status": "failure",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109641"
        },
        {
          "conclusion": "CANCELLED",
          "name": "test_win (3.11)",
          "run_id": 109116109650,
          "run_status": "completed",
          "status": "failure",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109650"
        },
        {
          "conclusion": "CANCELLED",
          "name": "test_win (3.12)",
          "run_id": 109116109555,
          "run_status": "completed",
          "status": "failure",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109555"
        },
        {
          "conclusion": "FAILURE",
          "name": "test_win (3.13)",
          "run_id": 109116109670,
          "run_status": "completed",
          "status": "failure",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109670"
        },
        {
          "conclusion": "CANCELLED",
          "name": "test_win (3.14)",
          "run_id": 109116109516,
          "run_status": "completed",
          "status": "failure",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109516"
        }
      ],
      "head_sha": "8d9ceb664aa467be85ea4c7467f810c2fdf2b69d",
      "id": "sha256:40167efe67cf0eb4d8baf39894b01256c734becc760c3ae9a25a92ee34e0446d",
      "required_checks": [
        "build",
        "lint",
        "test_linux (3.10)",
        "test_linux (3.11)",
        "test_linux (3.12)",
        "test_linux (3.13)",
        "test_linux (3.14)",
        "test_macos (3.10)",
        "test_macos (3.11)",
        "test_macos (3.12)",
        "test_macos (3.13)",
        "test_macos (3.14)",
        "test_win (3.10)",
        "test_win (3.11)",
        "test_win (3.12)",
        "test_win (3.13)",
        "test_win (3.14)"
      ],
      "status": "failure"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "build",
          "run_id": 109127304501,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481292865/job/109127304501"
        },
        {
          "conclusion": "SUCCESS",
          "name": "lint",
          "run_id": 109131968720,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131968720"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.10)",
          "run_id": 109131968802,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131968802"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.11)",
          "run_id": 109131969009,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969009"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.12)",
          "run_id": 109131969120,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969120"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.13)",
          "run_id": 109131968989,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131968989"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_linux (3.14)",
          "run_id": 109131969037,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969037"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.10)",
          "run_id": 109131969091,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969091"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.11)",
          "run_id": 109131968974,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131968974"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.12)",
          "run_id": 109131969514,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969514"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.13)",
          "run_id": 109131968918,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131968918"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_macos (3.14)",
          "run_id": 109131969194,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969194"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.10)",
          "run_id": 109131968901,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131968901"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.11)",
          "run_id": 109131969024,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969024"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.12)",
          "run_id": 109131969338,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969338"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.13)",
          "run_id": 109131968857,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131968857"
        },
        {
          "conclusion": "SUCCESS",
          "name": "test_win (3.14)",
          "run_id": 109131969028,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131969028"
        }
      ],
      "head_sha": "a5bad00b598ad91a5220838196b74f6575767db3",
      "id": "sha256:be209b007923092fc8e77e918f0b37988d00aec830dc9fb0aecc1f59051bd048",
      "required_checks": [
        "build",
        "lint",
        "test_linux (3.10)",
        "test_linux (3.11)",
        "test_linux (3.12)",
        "test_linux (3.13)",
        "test_linux (3.14)",
        "test_macos (3.10)",
        "test_macos (3.11)",
        "test_macos (3.12)",
        "test_macos (3.13)",
        "test_macos (3.14)",
        "test_win (3.10)",
        "test_win (3.11)",
        "test_win (3.12)",
        "test_win (3.13)",
        "test_win (3.14)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [
    {
      "evidence": [
        "https://github.com/hydra-ecosystem/hydra/actions/runs/36477904442/job/109116109670",
        "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293321/job/109131968857"
      ],
      "id": "caller-rooted-path-win-3485",
      "invariant": "caller:// paths must be relative on every platform",
      "locations": [
        "hydra/initialize.py:183",
        "tests/test_compose.py:287"
      ],
      "required_outcome": "Reject slash-rooted caller URI paths on Windows as on POSIX.",
      "status": "verified"
    },
    {
      "evidence": [
        "https://github.com/hydra-ecosystem/hydra/pull/3485#discussion_r4120039622",
        "https://github.com/hydra-ecosystem/hydra/actions/runs/36481293037"
      ],
      "id": "codeql-noop-enter-3485",
      "invariant": "New runtime method must not contain a no-effect ellipsis statement",
      "locations": [
        "hydra/initialize.py:212"
      ],
      "required_outcome": "Use an explicit no-op return in __enter__.",
      "status": "verified"
    }
  ],
  "pr": {
    "base_ref": "main",
    "base_sha": "2828aa0cf428ffbd8ce13811cf74cfa4f86abff0",
    "body_digest": "sha256:9021120851bf351ec9474c728b4a5c146a27cf3dce5b66e7f100efa69daa7790",
    "diff_digest": "sha256:27c22c1e4679d8802a88f53a6ac75abca4a976fca499ed43a0896c34e3b50dd1",
    "head_ref": "pr3485",
    "head_sha": "a5bad00b598ad91a5220838196b74f6575767db3",
    "pr": 3485,
    "repository": "hydra-ecosystem/hydra",
    "scope_authority": [],
    "title_digest": "sha256:f4bfdda64313be4b8b20c8a89c9270a56ee7eddb0e79395c31f9704eed518b60"
  },
  "record_version": 10,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-09-28T08:26:48Z",
      "base_ref": "main",
      "base_sha": "2828aa0cf428ffbd8ce13811cf74cfa4f86abff0",
      "body_digest": "sha256:57b578142e60bab428ae87aeae8a02e6101bb11510e0846e10cc28e32fbccf15",
      "created_at": "2026-09-28T08:48:44Z",
      "head_sha": "811ab06014449d6a3d13fe29d0d480857719ead8",
      "id": 5866587085,
      "kind": "regular-review"
    },
    {
      "base_established_at": "2026-09-28T08:26:48Z",
      "base_ref": "main",
      "base_sha": "2828aa0cf428ffbd8ce13811cf74cfa4f86abff0",
      "body_digest": "sha256:3114b144d64f6e823e055f57c64a84d82f44110864fd80801f8abd176e4bae54",
      "created_at": "2026-09-28T20:24:29Z",
      "head_sha": "8d9ceb664aa467be85ea4c7467f810c2fdf2b69d",
      "id": 5877832337,
      "kind": "regular-review"
    },
    {
      "base_established_at": "2026-09-28T08:26:48Z",
      "base_ref": "main",
      "base_sha": "2828aa0cf428ffbd8ce13811cf74cfa4f86abff0",
      "body_digest": "sha256:442cdad3724a026cc059508fb836e671b9ca672e75b349258c85d6f65de647ed",
      "created_at": "2026-09-28T20:49:03Z",
      "head_sha": "a5bad00b598ad91a5220838196b74f6575767db3",
      "id": 5878253768,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "main",
      "base_sha": "2828aa0cf428ffbd8ce13811cf74cfa4f86abff0",
      "body_digest": "sha256:f175de744f0bb82d156abd718081e380f43f16ba76f53a15ce63ca90ce316974",
      "commit_id": "811ab06014449d6a3d13fe29d0d480857719ead8",
      "id": 5866623545,
      "inline_message_ids": [],
      "request_comment_id": 5866587085,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-09-28T08:51:19Z",
      "unresolved_thread_ids": [
        "PRRT_kwDOC2wWEs6ml70f"
      ]
    },
    {
      "base_ref": "main",
      "base_sha": "2828aa0cf428ffbd8ce13811cf74cfa4f86abff0",
      "body_digest": "sha256:2d49d1d7533ca3821bf55ec6fbd4862a99becf316c35afbce5b603172fa3a0e1",
      "commit_id": "8d9ceb664aa467be85ea4c7467f810c2fdf2b69d",
      "id": 5877883123,
      "inline_message_ids": [],
      "request_comment_id": 5877832337,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-09-28T20:27:26Z",
      "unresolved_thread_ids": [
        "PRRT_kwDOC2wWEs6ml70f"
      ]
    },
    {
      "base_ref": "main",
      "base_sha": "2828aa0cf428ffbd8ce13811cf74cfa4f86abff0",
      "body_digest": "sha256:67747db7a062160ab2fd8ec7a63bd1e25f5ed0bd644b377643ce7a5131304b3d",
      "commit_id": "a5bad00b598ad91a5220838196b74f6575767db3",
      "id": 5878307796,
      "inline_message_ids": [],
      "request_comment_id": 5878253768,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-09-28T20:52:14Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:9cf2709ea7f496e9bc6870aa7f9bcba0ae87020f91d0fef0451e1f92d754e49d",
  "rounds": [
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:35c8e827aff810dd814cb152433121ab3b7a3e33f87897535a2953015906b92f",
      "finding_ids": [],
      "invariants": [
        "Ordered config source composition",
        "Existing initializer compatibility",
        "Public API documentation"
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "811ab06014449d6a3d13fe29d0d480857719ead8",
      "review_observation_id": null,
      "review_request_id": 5866587085,
      "review_result_id": 5866623545,
      "reviewed_head": "811ab06014449d6a3d13fe29d0d480857719ead8",
      "root_cause": null,
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [
        "hydra/initialize.py"
      ],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:27c22c1e4679d8802a88f53a6ac75abca4a976fca499ed43a0896c34e3b50dd1",
      "finding_ids": [
        "caller-rooted-path-win-3485",
        "codeql-noop-enter-3485"
      ],
      "invariants": [
        "caller:// paths must be relative on every platform",
        "New runtime method must not contain a no-effect ellipsis statement"
      ],
      "outcome": "corrected-head-needs-review",
      "proposed_fix_paths": [
        "hydra/initialize.py"
      ],
      "resulting_head": "a5bad00b598ad91a5220838196b74f6575767db3",
      "review_observation_id": null,
      "review_request_id": 5877832337,
      "review_result_id": 5877883123,
      "reviewed_head": "8d9ceb664aa467be85ea4c7467f810c2fdf2b69d",
      "root_cause": "OS-dependent absolute-path detection accepted a slash-rooted caller URI on Windows; a placeholder ellipsis also triggered CodeQL.",
      "round": 2,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:27c22c1e4679d8802a88f53a6ac75abca4a976fca499ed43a0896c34e3b50dd1",
      "finding_ids": [],
      "invariants": [
        "Ordered config source composition",
        "Existing initializer compatibility",
        "Platform-independent caller URI validation",
        "Public API documentation"
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "a5bad00b598ad91a5220838196b74f6575767db3",
      "review_observation_id": null,
      "review_request_id": 5878253768,
      "review_result_id": 5878307796,
      "reviewed_head": "a5bad00b598ad91a5220838196b74f6575767db3",
      "root_cause": null,
      "round": 3,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry
omry marked this pull request as ready for review September 28, 2026 08:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T20:52:15.628911Z a5bad00 Manual request
🔒 Security Review ✅ Completed 2026-09-28T08:44:04.968184Z 811ab06 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

@codex, regular review 811ab06

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 811ab06014

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved Accepted after review label Sep 28, 2026
@omry omry removed the approved Accepted after review label Sep 28, 2026
@omry

omry commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

@codex, regular review 8d9ceb6

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 8d9ceb664a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Expose an ordered URI-based Compose initializer so external configs can reference packaged defaults. Document its validation and lifecycle behavior, and test source precedence and context restoration.

Refs #3230.
@gitar-bot

gitar-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Adds ordered config-source resolution and changes absolute-path behavior in Compose initialization.

Exposes an ordered URI-based Compose initializer for external configs to reference packaged defaults, with validation and lifecycle behavior documented and source precedence tested. No issues found.

Review coverage

📋 Rules No rules evaluated

🧪 Functional validation Not enabled · Set up

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Counting what did not apply, without listing it.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@omry

omry commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator Author

@codex, regular review a5bad00

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: a5bad00b59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved Accepted after review label Sep 28, 2026
@omry
omry merged commit 8980717 into main Sep 28, 2026
26 of 45 checks passed
@omry
omry deleted the pr3485 branch September 28, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Accepted after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants