Repository navigation
Add 'how to define spans' meta-guidance - #3240
Conversation
0b17b67 to
a2914f1
Compare
|
Is there a reason not to include a changelog entry? #2232 was listed as a doc enhancement. |
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
3dbd5dd to
15ef301
Compare
good question. In my view changelog is a summary of things that have changed that's relevant to consumers. This doc does not change any conventions and users don't need to be notified. In this sense, it's similar to CI fixes and internal docs updates. As you noticed we're not consistent and some PRs include changelog even when they don't change anything for consumers. |
I feel that we could count writers of decentralized semantic conventions as consumers. |
|
@kamphaus make sense, I added the changelog. Would you be interested in updating contrib.md to document this policy - https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#when-to-add-a-changelog-entry ? |
Done: #3329 |
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Fixes #1853