Skip to content

fix(action): no need to modify path for extras - #2673

Closed
henryiii wants to merge 1 commit into
mainfrom
henryiii/fix/simpleraction
Closed

henryiii wants to merge 1 commit into
mainfrom
henryiii/fix/simpleraction

Conversation

@henryiii

Copy link
Copy Markdown
Contributor

Try simpler action. See #2663.

Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
@mayeut

mayeut commented Dec 7, 2025

Copy link
Copy Markdown
Member

I'm not sure why this had an impact as you mentioned in #2663 (comment), maybe we should add a backend test (meson-python, scikit-build-core, maturin) ?

uv is still used directly in the virtualenv function and pip on Windows

call("uv", "venv", venv_path, "--python", python)

pip = ["uv", "pip"] if use_uv else ["pip"]

@henryiii

Copy link
Copy Markdown
Contributor Author

Should we fix the direct usage, then?

@joerick

joerick commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

Thanks for this henryiii! I think both are a good idea - removing the direct uv usage and adding a test for an alternate backend.

Do we understand why the action change causes an issue with link.exe in meson-python? I don't see how that relates... regardless this solution seems good to me.

@joerick

joerick commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

Since I'd like to keep the extras: uv functionality, I've raised an alternative PR - #2723 - that keeps that working while avoiding the PATH changes that are causing the issue seen in #2663.

@henryiii henryiii closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants