Repository navigation
Conversation
|
Documentation preview for this PR (built with commit a092744; changes) is ready! 🎉 |
orlitzky
force-pushed
the
warn-longer-on-macos
branch
2 times, most recently
from
September 7, 2026 23:37
d138072 to
76f5814
Compare
orlitzky
marked this pull request as ready for review
September 11, 2026 15:46
Contributor
Author
|
The CI looks bad, but they're all bogus. To see that it's working, check one of the macOS jobs:
|
cxzhong
reviewed
Sep 15, 2026
orlitzky
force-pushed
the
warn-longer-on-macos
branch
from
September 20, 2026 14:49
e4901f8 to
72295a1
Compare
orlitzky
force-pushed
the
warn-longer-on-macos
branch
from
September 30, 2026 23:26
72295a1 to
3bfb5fe
Compare
orlitzky
force-pushed
the
warn-longer-on-macos
branch
from
October 18, 2026 12:24
3bfb5fe to
a092744
Compare
orlitzky
force-pushed
the
warn-longer-on-macos
branch
from
November 3, 2026 12:36
a092744 to
940d830
Compare
Substitution is slow on macOS, sagemath#40825 causing several tests to raise "slow doctest" warnings on the CI. These aren't real problems (beyond the fact that substitution is slow), and warnings for actually-long tests will still be raised by other jobs, so let's set the warning limit to 60s on macOS.
Ensure that non-macOS runners get an empty string in lieu of an extended --warn-long.
orlitzky
force-pushed
the
warn-longer-on-macos
branch
from
November 16, 2026 17:12
940d830 to
4955ec4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substitution is slow on macOS, causing several tests to raise "slow doctest" warnings on the CI. These aren't real problems (beyond the fact that substitution is slow), and warnings for actually-long tests will still be raised by other jobs, so let's set the warning limit to 60s on macOS.
The main goal here is to hide these warnings from Github's "changes" view, since they appear to indicate a new problem in that context. But it's also nice to just not have them show up (grep, etc.) in the list of tests that should be sped-up or marked
# long time.Example (scroll to the bottom): https://github.com/sagemath/sage/pull/42775/changes