Skip to content

.github/workflows: raise the "slow doctest" limit on macOS - #42768

Open
orlitzky wants to merge 2 commits into
sagemath:developfrom
orlitzky:warn-longer-on-macos
Open

orlitzky wants to merge 2 commits into
sagemath:developfrom
orlitzky:warn-longer-on-macos

Conversation

@orlitzky

@orlitzky orlitzky commented Sep 7, 2026 •

Copy link
Copy Markdown
Contributor

Substitution is slow on macOS, causing several tests to raise "slow doctest" warnings on the CI. These aren't real problems (beyond the fact that substitution is slow), and warnings for actually-long tests will still be raised by other jobs, so let's set the warning limit to 60s on macOS.

The main goal here is to hide these warnings from Github's "changes" view, since they appear to indicate a new problem in that context. But it's also nice to just not have them show up (grep, etc.) in the list of tests that should be sped-up or marked # long time.

Example (scroll to the bottom): https://github.com/sagemath/sage/pull/42775/changes

@orlitzky
orlitzky marked this pull request as draft September 7, 2026 18:11
@github-actions

github-actions Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Documentation preview for this PR (built with commit a092744; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@orlitzky
orlitzky force-pushed the warn-longer-on-macos branch 2 times, most recently from d138072 to 76f5814 Compare September 7, 2026 23:37
@orlitzky
orlitzky marked this pull request as ready for review September 11, 2026 15:46
@orlitzky

Copy link
Copy Markdown
Contributor Author

The CI looks bad, but they're all bogus. To see that it's working, check one of the macOS jobs:

  • --warn-long 60.0 is visible during testing
  • There are no "slow doctest" warnings

Comment thread .github/workflows/ci-meson.yml Resolved
Substitution is slow on macOS,

  sagemath#40825

causing several tests to raise "slow doctest" warnings on the
CI. These aren't real problems (beyond the fact that substitution is
slow), and warnings for actually-long tests will still be raised by
other jobs, so let's set the warning limit to 60s on macOS.
Ensure that non-macOS runners get an empty string in lieu of an
extended --warn-long.
@orlitzky
orlitzky force-pushed the warn-longer-on-macos branch from 940d830 to 4955ec4 Compare November 16, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants