Repository navigation
[DeepSeek V4] Fix stale override wording in ROCm FlashMLA sparse-prefill disable - #30289
Closed
michaelzhang-ai wants to merge 1 commit into
Closed
michaelzhang-ai wants to merge 1 commit into
michaelzhang-ai wants to merge 1 commit into
Conversation
…ill disable #30237 made the ROCm/HIP disable of SGLANG_OPT_FLASHMLA_SPARSE_PREFILL unconditional (dropped the is_set() check), but the warning message and comment still claimed the env var could be set to override it. Update the wording to match the actual behavior.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Collaborator
Author
|
Context: this is a docs/log-string-only follow-up to #30237 (no behavior change). Related disagg validation run (image Note that run shows the DeepSeek-V4-Flash disagg configs still failing — but the cause is a MORI/RDMA prefill crash ( |
alexnails
restored the
michaelzhang-ai/dsv4-flashmla-warning-wording
branch
September 14, 2026 05:43
cursor
Bot
deleted the
michaelzhang-ai/dsv4-flashmla-warning-wording
branch
September 17, 2026 07:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#30237 made the ROCm/HIP disable of
SGLANG_OPT_FLASHMLA_SPARSE_PREFILLunconditional (dropped theis_set()check), which is correct — but the warning message and preceding comment still say the env var can be set explicitly to override, which is no longer true. This was also raised by the gemini review bot on #30237.Modifications
python/sglang/srt/arg_groups/deepseek_v4_hook.py: update the comment andlogger.warningtext to reflect that the flag is unconditionally disabled on ROCm/HIP until the sparse prefill kernel is validated there. No behavior change.Accuracy Tests
Comment/log-string only; no functional change.
Checklist
CI States
Latest PR Test (Base): ❌ Run #28817248929
Latest PR Test (Extra): ❌ Run #28817248875