Repository navigation
[Quant] Preserve ModelOpt FP4 quantization for NextN drafts - #37322
Open
usr-bin-roygbiv wants to merge 3 commits into
Open
usr-bin-roygbiv wants to merge 3 commits into
usr-bin-roygbiv wants to merge 3 commits into
Conversation
usr-bin-roygbiv
requested review from
Alisehen,
AniZpZ,
BBuf,
Edwardf0t1,
FlamingoPg,
HaiShaw,
OrangeRedeng,
b8zhong,
ch-wan and
mmangkad
as code owners
September 1, 2026 01:22
Author
|
/tag-and-rerun-ci |
Author
|
Hi @HaiShaw — could you add the |
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #36599 and addresses the draft-load failure described in #36653.
DeepseekModelNextNandBailingMoEModelNextNcurrently forcemodelopt_fp4quantization toNone. That makes quantized GLM-5.3-Flash NextN/MTP weights load into BF16 modules and fail with a packed-versus-unpacked shape mismatch.Modifications
modelopt_fp4toNoneoverride from the DeepSeek and Bailing NextN paths while preserving the legacy GLM-4.x and GLM-OCR overrides.Accuracy Tests
Result:
75 passed, 15 warnings, 30 subtests passed in 13.77s.The unit coverage exercises loader mapper ordering and the downstream ModelOpt
get_quant_methoddecisions. No full ModelOpt FP4 checkpoint load, speculative-decoding run, or model-output accuracy run was performed locally.Speed Tests and Profiling
This changes NextN module construction and checkpoint weight-loading precision selection; it does not add a kernel benchmark. No throughput benchmark or profiler run was performed.
Relationship to Other Work
The branch starts from an older
mainancestor (88cf5c9541); the intervening upstream commits do not touch this PR's changed paths. The branch should be rebased after the overlapping PRs above land.Checklist
CI States
Latest PR Test (Base): ❌ Run #33458470679
Latest PR Test (Extra): ❌ Run #33458470537
Latest PR Test (AMD ROCm 7.2): ❌ Run #33458470657