fix: drop the Omni API URL check on IP address

I don't see much point in this check, as it's only valuable when joining
to a local development instance of Omni, which is pretty nice usecase.

But this check breaks joining to "real" Omni which has hostname in the
endpoint.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 0592ff0)

Author: smira

cmd/talosctl/cmd/mgmt/cluster/create/clusterops/configmaker/internal/makers/common.go

@@ -261,12 +261,7 @@ func (m *Maker[T]) applyOmniConfigs() error {
 
 	cfg.APIUrlConfig.URL = parsedURL
 
-	mode, err := runtime.ParseMode(runtime.ModeMetal.String())
-	if err != nil {
-		return err
-	}
-
-	_, err = cfg.Validate(mode)
+	_, err = cfg.Validate(runtime.ModeMetal)
 	if err != nil {
 		return err
 	}

cmd/talosctl/cmd/mgmt/cluster/create/create_qemu.go

@@ -7,7 +7,6 @@ package create
 import (
 	"context"
 	"fmt"
-	"net/netip"
 	"net/url"
 	"os"
 	"path/filepath"
@@ -100,13 +99,6 @@ func createQemuCluster(
 }
 
 func preCreate(cOps clusterops.Common, clusterConfigs clusterops.ClusterConfigs) error {
-	if cOps.OmniAPIEndpoint != "" {
-		err := checkLoopbackOmniURL(cOps, clusterConfigs)
-		if err != nil {
-			return err
-		}
-	}
-
 	// write machine config
 	if cOps.SkipInjectingConfig {
 		if err := writeMachineconfig(clusterConfigs, cOps); err != nil {
@@ -143,26 +135,3 @@ func writeMachineconfig(clusterConfigs clusterops.ClusterConfigs, cOps clusterop
 
 	return nil
 }
-
-func checkLoopbackOmniURL(cOps clusterops.Common, clusterConfigs clusterops.ClusterConfigs) error {
-	parsedURL, err := url.Parse(cOps.OmniAPIEndpoint)
-	if err != nil {
-		return err
-	}
-
-	host := parsedURL.Hostname()
-
-	ip, err := netip.ParseAddr(host)
-	if err != nil {
-		return err
-	}
-
-	gwIP := clusterConfigs.ClusterRequest.Network.GatewayAddrs[0]
-
-	if ip.IsLoopback() && ip != gwIP {
-		fmt.Fprintf(os.Stderr, "WARNING: the Omni API url is pointing to a local address %q which is different from the cluster gateway address %q\n", ip.String(), gwIP.String())
-		fmt.Fprintln(os.Stderr, "the nodes will not be able to reach the Omni API server unless Omni is running in the same virtual network")
-	}
-
-	return nil
-}