Skip to content

fix(mtp): Disable DiffEngine and the Verify clipboard feature - #3547

Merged
rouke-broersma merged 1 commit into
stryker-mutator:masterfrom
0xced:snapshot-disable-mtp
Apr 13, 2026
Merged

rouke-broersma merged 1 commit into
stryker-mutator:masterfrom
0xced:snapshot-disable-mtp

Conversation

@0xced

@0xced 0xced commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

The DiffEngine_Disabled and Verify_DisableClipboard environment variables are set for the VSTest runner. They should also be set for the MTP runner.

Copilot AI review requested due to automatic review settings April 13, 2026 19:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the Microsoft Test Platform (MTP) runner behavior with the VsTest runner by ensuring approval-test-related environment variables are set to prevent DiffEngine UI launches and Verify clipboard usage during test execution.

Changes:

  • Added a shared ExternalEnvironmentVariables helper to centralize runner-specific environment variable setup.
  • Refactored the VsTest host launcher to use the shared helper.
  • Updated the MTP runner to include these environment variables when building its per-runner environment.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/Stryker.TestRunner/ExternalEnvironmentVariables.cs Introduces a shared helper to apply DiffEngine/Verify environment variables.
src/Stryker.TestRunner.VsTest/StrykerVstestHostLauncher.cs Replaces inline environment variable setup with the shared helper.
src/Stryker.TestRunner.MicrosoftTestPlatform/SingleMicrosoftTestPlatformRunner.cs Applies the shared environment variable setup to MTP runner process environment.

The DiffEngine_Disabled and Verify_DisableClipboard environment variables are set for the VSTest runner. They should also be set for the MTP runner.
@0xced
0xced force-pushed the snapshot-disable-mtp branch from a2f172e to 978c68d Compare April 13, 2026 20:14
@rouke-broersma rouke-broersma changed the title Disable DiffEngine and the Verify clipboard feature for the MTP runner fix(mtp): Disable DiffEngine and the Verify clipboard feature Apr 13, 2026
@rouke-broersma
rouke-broersma merged commit f7b2f20 into stryker-mutator:master Apr 13, 2026
39 checks passed
@0xced
0xced deleted the snapshot-disable-mtp branch April 14, 2026 00:12
tknightnd pushed a commit to NewDayTechnology/benchmarkdotnet.analyser that referenced this pull request May 20, 2026
Updated
[coverlet.collector](https://github.com/coverlet-coverage/coverlet) from
10.0.0 to 10.0.1.

<details>
<summary>Release notes</summary>

_Sourced from [coverlet.collector's
releases](https://github.com/coverlet-coverage/coverlet/releases)._

## 10.0.1

### Improvements

- Coverlet with MTP 2 doesn't show test coverage statistic in console
[#​1907](coverlet-coverage/coverlet#1907)
- Avoid unnecessary testhost restarts
[#​1912](coverlet-coverage/coverlet#1912) by
<https://github.com/mawosoft>

### Fixed

- Fix inconsistent paths in cobertura reports
[#​1723](coverlet-coverage/coverlet#1723)
- Fix when using "is" with "and" in pattern matching, branch coverage is
lower than normal
[#​1313](coverlet-coverage/coverlet#1313)
- Fix Coverlet flagging a branch for an async functions finally block
where none exists
[#​1337](coverlet-coverage/coverlet#1337)
- Fix Coverlet Tracker Missing CompilerGeneratedAttribute
[#​1828](coverlet-coverage/coverlet#1828)

### Maintenance

- Add architecture docs and diagrams for all integrations
[#​1927](coverlet-coverage/coverlet#1927)
- Update NuGet packages and .NET SDK versions
[#​1933](coverlet-coverage/coverlet#1933)

[Diff between 10.0.0 and
10.0.1](coverlet-coverage/coverlet@v10.0.0...v10.0.1)

Commits viewable in [compare
view](coverlet-coverage/coverlet@v10.0.0...v10.0.1).
</details>

Updated
[coverlet.msbuild](https://github.com/coverlet-coverage/coverlet) from
10.0.0 to 10.0.1.

<details>
<summary>Release notes</summary>

_Sourced from [coverlet.msbuild's
releases](https://github.com/coverlet-coverage/coverlet/releases)._

## 10.0.1

### Improvements

- Coverlet with MTP 2 doesn't show test coverage statistic in console
[#​1907](coverlet-coverage/coverlet#1907)
- Avoid unnecessary testhost restarts
[#​1912](coverlet-coverage/coverlet#1912) by
<https://github.com/mawosoft>

### Fixed

- Fix inconsistent paths in cobertura reports
[#​1723](coverlet-coverage/coverlet#1723)
- Fix when using "is" with "and" in pattern matching, branch coverage is
lower than normal
[#​1313](coverlet-coverage/coverlet#1313)
- Fix Coverlet flagging a branch for an async functions finally block
where none exists
[#​1337](coverlet-coverage/coverlet#1337)
- Fix Coverlet Tracker Missing CompilerGeneratedAttribute
[#​1828](coverlet-coverage/coverlet#1828)

### Maintenance

- Add architecture docs and diagrams for all integrations
[#​1927](coverlet-coverage/coverlet#1927)
- Update NuGet packages and .NET SDK versions
[#​1933](coverlet-coverage/coverlet#1933)

[Diff between 10.0.0 and
10.0.1](coverlet-coverage/coverlet@v10.0.0...v10.0.1)

Commits viewable in [compare
view](coverlet-coverage/coverlet@v10.0.0...v10.0.1).
</details>

Updated [dotnet-stryker](https://github.com/stryker-mutator/stryker-net)
from 4.14.1 to 4.14.2.

<details>
<summary>Release notes</summary>

_Sourced from [dotnet-stryker's
releases](https://github.com/stryker-mutator/stryker-net/releases)._

## 4.14.2

##
[4.14.2](https://github.com/stryker-mutator/stryker-net/compare/dotnet-stryker@​4.14.1...dotnet-stryker@​4.14.2)
(2026-05-17)


### Bug Fixes

* **mtp:** attribute error/timed-out/cancelled states as failures
([#​3560](stryker-mutator/stryker-net#3560))
([58969ca](stryker-mutator/stryker-net@58969ca)),
closes
[#​3094](stryker-mutator/stryker-net#3094)
* **mtp:** Disable DiffEngine and the Verify clipboard feature
([#​3547](stryker-mutator/stryker-net#3547))
([f7b2f20](stryker-mutator/stryker-net@f7b2f20))
* **mutating:** out var in lambdas triggering NRE
([#​3575](stryker-mutator/stryker-net#3575))
([5ce07cc](stryker-mutator/stryker-net@5ce07cc))
* **rollback:** Improve rollback for CS0165 and CS0177 compile errors
([#​3548](stryker-mutator/stryker-net#3548))
([b42be0e](stryker-mutator/stryker-net@b42be0e))


Commits viewable in [compare
view](https://github.com/stryker-mutator/stryker-net/compare/dotnet-stryker@​4.14.1...dotnet-stryker@​4.14.2).
</details>

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants