Skip to content

io: Implement skip_until - #7479

Open
WilliamVenner wants to merge 4 commits into
tokio-rs:masterfrom
WilliamVenner:feat/skip_until
Open

WilliamVenner wants to merge 4 commits into
tokio-rs:masterfrom
WilliamVenner:feat/skip_until

Conversation

@WilliamVenner

Copy link
Copy Markdown
Contributor

Motivation

std::io::BufRead::skip_until was stabilized in Rust 1.83.0. Let's implement it into Tokio, too.

Solution

I have simply adapted existing read_until code to discard the read bytes rather than writing them in to a buffer.

@WilliamVenner WilliamVenner changed the title Implement skip_until io: Implement skip_until Jul 23, 2025
@ADD-SP

ADD-SP commented Jul 24, 2025

Copy link
Copy Markdown
Member

This breaks the MSRV, current MSRV is Rust 1.70, this requires 1.83.

@ADD-SP ADD-SP added A-tokio-util Area: The tokio-util crate A-tokio Area: The main tokio crate M-io Module: tokio/io C-enhancement Category: A PR with an enhancement or bugfix. S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. labels Jul 24, 2025
@mox692 mox692 added the S-blocked-on-msrv Status: need an MSRV bump to progress label Jul 28, 2025
@ADD-SP ADD-SP removed the S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. label Aug 22, 2025
@Darksonn Darksonn added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked-on-msrv Status: need an MSRV bump to progress labels Sep 26, 2026
@github-actions github-actions Bot added the R-loom-util Run loom tokio-util tests on this PR label Sep 26, 2026
@Darksonn

Copy link
Copy Markdown
Member

We bumped the MSRV, and this can now land (but there's a CI failure).

Are you still interested in working on this?

@Darksonn Darksonn added S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tokio Area: The main tokio crate A-tokio-util Area: The tokio-util crate C-enhancement Category: A PR with an enhancement or bugfix. M-io Module: tokio/io R-loom-util Run loom tokio-util tests on this PR S-waiting-on-author Status: awaiting some action (such as code changes) from the PR or issue author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants