Skip to content

chore: update MSRV to 1.84 - #7610

Closed
timsaucer wants to merge 6 commits into
tokio-rs:masterfrom
timsaucer:chore/msrv-1.84
Closed

timsaucer wants to merge 6 commits into
tokio-rs:masterfrom
timsaucer:chore/msrv-1.84

Conversation

@timsaucer

Copy link
Copy Markdown

This updates the MSRV to 1.84 in accordance with the stated 6 month policy. 1.84.1 was released Jan 30, 2025.

https://blog.rust-lang.org/2025/01/30/Rust-1.84.1/

Motivation

Some downstream crates, such as prost, keep in line with tokio's MSRV. This allows for updating some of the other dependencies, such as petgraph, which require 1.81 or later for no-std.

Solution

Update MSRV in accordance with policy.

@Darksonn

Copy link
Copy Markdown
Member

The MSRV policy is at least six months, but we don't actually update it unless we actually need something from the new version.

Why should we update? And why to that version?

@github-actions github-actions Bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-sync Run loom sync tests on this PR labels Sep 11, 2025
@timsaucer

Copy link
Copy Markdown
Author

Understood if you need additional justification. The feature we wish to use was introduced in version 1.81, stabilizing core::error::Error for use with #![no_std].

If this is something the project is wiling to support I can also update this PR to set it to 1.81. If that is not sufficient justification, I can understand and we will attempt to work around in another way with our dependencies.

@Darksonn

Copy link
Copy Markdown
Member

In general, the justification for increasing Tokio's MSRV should be because Tokio itself needs the new feature. Tokio isn't going to follow petgraph's MSRV.

@timsaucer

Copy link
Copy Markdown
Author

I can certainly understand that position. I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-sync Run loom sync tests on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants