Repository navigation
Conversation
broofa
marked this pull request as ready for review
April 6, 2026 16:47
crypto to be global everywherecrypto to be global everywhere (requires node@20+)
|
Very cool. Thank you! |
6 tasks
|
hi! will this update break usage of uuid in non-secure browser contexts? we are relying on uuid over crypto due to crypto.randomUUID not being available in non-https environments. |
|
I haven’t tested it myself but if I’m reading the code right it’ll fallback to crypto.randomValues() if crypto.randomUUID() is not present. |
i just tested this myself, and in contrast to my assumptions |
Member
Author
1 of 5 tasks
6 tasks done
zeekay
pushed a commit
to hanzoai/uuid
that referenced
this pull request
Sep 9, 2026
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Now that
cryptois globally defined everywhere (all browser environments and node@20+), we can clean up the feature detection logic we had around it.typeof cryptofeature-detectionrng-browser.tsnative*.tsCloses #891