Repository navigation
Commit 189ed48
This PR cherry-picks changes from the original PR #10162 to branch 25.3.
---
#### Original PR description
> ## Description
>
> Related to #10154
>
> Found by the line-removal mutation testing in #10154, which only added
tests and left the defects for a separate fix.
>
> - Fixed `resolveX` so OHLC, Range and Flags data without an `_x`
column gets the row index as X instead of `null`
> - Every caller passes the `_x` constant, so the `rowIndex` fallback
was unreachable
> - Excluded the `_color` marker column from the fallback's category and
value column classification
> - `{revenue: 1000, _color: "#FF0000"}` produced points named
`#FF0000`, and two numeric columns plus `_color` were converted as
category and value instead of X and Y
> - Added tests for OHLC, Range and Flags data without `_x` and for the
fallback with a `_color` column
>
> ## Type of change
>
> - Bugfix
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent a2f4d13 commit 189ed48
2 files changed
Lines changed: 61 additions & 1 deletion
File tree
- vaadin-ai-components-flow-parent/vaadin-ai-extensions-flow/src
- main/java/com/vaadin/flow/component/ai/chart
- test/java/com/vaadin/flow/component/ai/chart
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| 101 | + | |
| 102 | + | |
101 | 103 | | |
102 | 104 | | |
103 | 105 | | |
| |||
609 | 611 | | |
610 | 612 | | |
611 | 613 | | |
| 614 | + | |
| 615 | + | |
612 | 616 | | |
| 617 | + | |
613 | 618 | | |
614 | 619 | | |
615 | 620 | | |
| |||
762 | 767 | | |
763 | 768 | | |
764 | 769 | | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
765 | 774 | | |
766 | 775 | | |
767 | | - | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
768 | 779 | | |
769 | 780 | | |
770 | 781 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
140 | 140 | | |
141 | 141 | | |
142 | 142 | | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
143 | 152 | | |
144 | 153 | | |
145 | 154 | | |
| |||
563 | 572 | | |
564 | 573 | | |
565 | 574 | | |
| 575 | + | |
| 576 | + | |
| 577 | + | |
| 578 | + | |
| 579 | + | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
566 | 585 | | |
567 | 586 | | |
568 | 587 | | |
| |||
579 | 598 | | |
580 | 599 | | |
581 | 600 | | |
| 601 | + | |
| 602 | + | |
| 603 | + | |
| 604 | + | |
| 605 | + | |
| 606 | + | |
| 607 | + | |
| 608 | + | |
582 | 609 | | |
583 | 610 | | |
584 | 611 | | |
| |||
710 | 737 | | |
711 | 738 | | |
712 | 739 | | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
713 | 762 | | |
714 | 763 | | |
715 | 764 | | |
| |||
0 commit comments