Skip to content

Commit 4972973

Browse files
authored
fix: prevent filter on popup open (#4122)
1 parent e41f55f commit 4972973

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

  • vaadin-spreadsheet-flow-parent/vaadin-spreadsheet-flow/src

‎vaadin-spreadsheet-flow-parent/vaadin-spreadsheet-flow/src/main/java/com/vaadin/flow/component/spreadsheet/ItemFilter.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,7 @@ public void updateOptions() {
246246
cancelValueChangeUpdate = false;
247247
filterOptionsProvider = new ListDataProvider<>(filterOptions);
248248
filterCheckbox.setItems(filterOptionsProvider);
249+
firstUpdate = true;
249250
filterCheckbox.setValue(visibleValues);
250251
}
251252

‎vaadin-spreadsheet-flow-parent/vaadin-spreadsheet-flow/src/test/java/com/vaadin/flow/component/spreadsheet/tests/FilterTableTest.java‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,16 @@ public void registerFilter_uknownPopupButton_throws() {
138138
table.registerFilter(new PopupButton(), getItemFilter());
139139
}
140140

141+
@Test
142+
public void filteredTable_unhideRowAndOpenPopup_rowIsUnhidden() {
143+
getFilterCheckboxGroup().deselect("4");
144+
145+
spreadsheet.setRowHidden(3, false);
146+
getPopupButton().openPopup();
147+
148+
Assert.assertFalse(spreadsheet.isRowHidden(3));
149+
}
150+
141151
private CheckboxGroup<String> getFilterCheckboxGroup() {
142152
return (CheckboxGroup<String>) getItemFilter().getChildren()
143153
.filter(component -> component instanceof CheckboxGroup)

0 commit comments

Comments
 (0)