Skip to content

Commit 8187c9b

Browse files
ugur-vaadinvursen
andauthored
test: cleanup side nav test page (#5148)
* refactor: clear unused variations * fix: revert item order and reintroduce path to child item * Update vaadin-side-nav-flow-parent/vaadin-side-nav-flow-integration-tests/src/main/java/com/vaadin/flow/component/sidenav/tests/SideNavPage.java Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com> * Update vaadin-side-nav-flow-parent/vaadin-side-nav-flow-integration-tests/src/main/java/com/vaadin/flow/component/sidenav/tests/SideNavPage.java Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com> --------- Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
1 parent 66493f9 commit 8187c9b

1 file changed

Lines changed: 6 additions & 41 deletions

File tree

  • vaadin-side-nav-flow-parent/vaadin-side-nav-flow-integration-tests/src/main/java/com/vaadin/flow/component/sidenav/tests

‎vaadin-side-nav-flow-parent/vaadin-side-nav-flow-integration-tests/src/main/java/com/vaadin/flow/component/sidenav/tests/SideNavPage.java‎

Lines changed: 6 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,8 @@
1515
*/
1616
package com.vaadin.flow.component.sidenav.tests;
1717

18-
import com.vaadin.flow.component.avatar.Avatar;
1918
import com.vaadin.flow.component.html.Div;
2019
import com.vaadin.flow.component.html.NativeButton;
21-
import com.vaadin.flow.component.icon.VaadinIcon;
2220
import com.vaadin.flow.component.sidenav.SideNav;
2321
import com.vaadin.flow.component.sidenav.SideNavItem;
2422
import com.vaadin.flow.router.Route;
@@ -40,41 +38,19 @@ public SideNavPage() {
4038
SideNavItem nonNavigableParent = new SideNavItem(
4139
"Non-navigable parent");
4240
nonNavigableParent.setId("non-navigable-parent");
41+
nonNavigableParent.addItem(new SideNavItem("Item 1"));
42+
nonNavigableParent.addItem(new SideNavItem("Item 2"));
43+
nonNavigableParent.addItem(new SideNavItem("Item 3"));
4344
sideNav.addItem(nonNavigableParent);
4445

45-
SideNavItem labelOnly = new SideNavItem("Label only");
46-
labelOnly.setId("label-only");
47-
nonNavigableParent.addItem(labelOnly);
48-
49-
SideNavItem classTarget = new SideNavItem("Target using class",
50-
SideNavTargetView.class);
51-
classTarget.setId("class-target");
52-
nonNavigableParent.addItem(classTarget);
53-
54-
Avatar vaadinAvatar = new Avatar("Vaadin");
55-
SideNavItem classTargetWithComponent = new SideNavItem(
56-
"Target using class with component", SideNavTargetView.class,
57-
vaadinAvatar);
58-
classTargetWithComponent.setId("class-target-prefix-component");
59-
nonNavigableParent.addItem(classTargetWithComponent);
60-
6146
SideNavItem navigableParent = new SideNavItem("Navigable parent",
6247
"vaadin-side-nav/side-nav-test-target-view");
6348
navigableParent.setId("navigable-parent");
49+
navigableParent.addItem(new SideNavItem("Item 1",
50+
"vaadin-side-nav/side-nav-test-target-view"));
51+
navigableParent.addItem(new SideNavItem("Item 2"));
6452
sideNav.addItem(navigableParent);
6553

66-
SideNavItem pathTarget = new SideNavItem("Target using path",
67-
"vaadin-side-nav/side-nav-test-target-view");
68-
pathTarget.setId("path-target");
69-
navigableParent.addItem(pathTarget);
70-
71-
SideNavItem pathTargetWithIcon = new SideNavItem(
72-
"Target using path with icon",
73-
"vaadin-side-nav/side-nav-test-target-view",
74-
VaadinIcon.GLOBE.create());
75-
pathTargetWithIcon.setId("path-target-icon");
76-
navigableParent.addItem(pathTargetWithIcon);
77-
7854
Div expandedStatePrintout = new Div();
7955
expandedStatePrintout.setId("expanded-state-printout");
8056
add(expandedStatePrintout);
@@ -92,16 +68,5 @@ public SideNavPage() {
9268
printExpandedState.setId("print-side-nav-expanded-state");
9369
add(printExpandedState);
9470

95-
NativeButton test = new NativeButton("test",
96-
event -> navigableParent.setLabel(null));
97-
add(test);
98-
99-
NativeButton test2 = new NativeButton("test2",
100-
event -> navigableParent.setLabel(""));
101-
add(test2);
102-
103-
NativeButton test3 = new NativeButton("test3",
104-
event -> navigableParent.setLabel("aaa"));
105-
add(test3);
10671
}
10772
}

0 commit comments

Comments
 (0)