Skip to content

Commit db86805

Browse files
fix: return empty string if no summary text defined (#3172) (#3173)
Co-authored-by: Diego Cardoso <diego@vaadin.com>
1 parent 4e5719a commit db86805

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

  • vaadin-details-flow-parent/vaadin-details-flow/src

‎vaadin-details-flow-parent/vaadin-details-flow/src/main/java/com/vaadin/flow/component/details/Details.java‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,10 +214,11 @@ public void setSummaryText(String summary) {
214214
}
215215

216216
/**
217-
* @return summary section content as string
217+
* @return summary section content as string (empty string if nothing was
218+
* set)
218219
*/
219220
public String getSummaryText() {
220-
return summary.getElement().getText();
221+
return summary == null ? "" : summary.getElement().getText();
221222
}
222223

223224
/**

‎vaadin-details-flow-parent/vaadin-details-flow/src/test/java/com/vaadin/flow/component/details/DetailsTest.java‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,15 @@ public void initContent() {
2323
details.setContent(new Span());
2424
Assert.assertEquals(1, details.getContent().count());
2525
}
26+
27+
@Test
28+
public void noSummaryDefined_getSummaryText_returnsEmptyString() {
29+
Assert.assertEquals("", details.getSummaryText());
30+
}
31+
32+
@Test
33+
public void summaryDefined_getSummaryText_returnsStringDefined() {
34+
details.setSummaryText("summary");
35+
Assert.assertEquals("summary", details.getSummaryText());
36+
}
2637
}

0 commit comments

Comments
 (0)