Skip to content

Commit de195ad

Browse files
refactor!: remove map feature flag (#3474)
* refactor!: remove map feature flag * restore feature flag settings in ITs Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
1 parent 19cb2c1 commit de195ad

3 files changed

Lines changed: 0 additions & 108 deletions

File tree

‎vaadin-map-flow-parent/vaadin-map-flow/src/main/java/com/vaadin/flow/component/map/ExperimentalFeatureException.java‎

Lines changed: 0 additions & 23 deletions
This file was deleted.

‎vaadin-map-flow-parent/vaadin-map-flow/src/main/java/com/vaadin/flow/component/map/MapBase.java‎

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,11 @@
1616
* #L%
1717
*/
1818

19-
import com.vaadin.experimental.FeatureFlags;
2019
import com.vaadin.flow.component.AttachEvent;
2120
import com.vaadin.flow.component.Component;
2221
import com.vaadin.flow.component.ComponentEventListener;
2322
import com.vaadin.flow.component.HasSize;
2423
import com.vaadin.flow.component.HasTheme;
25-
import com.vaadin.flow.component.UI;
2624
import com.vaadin.flow.component.map.configuration.AbstractConfigurationObject;
2725
import com.vaadin.flow.component.map.configuration.Configuration;
2826
import com.vaadin.flow.component.map.configuration.Coordinate;
@@ -95,7 +93,6 @@ public void setView(View view) {
9593
@Override
9694
protected void onAttach(AttachEvent attachEvent) {
9795
super.onAttach(attachEvent);
98-
checkFeatureFlag();
9996
getElement().executeJs("window.Vaadin.Flow.mapConnector.init(this)");
10097
// Ensure the full configuration is synced when (re-)attaching the
10198
// component
@@ -219,35 +216,6 @@ public Registration addFeatureClickListener(
219216
return addListener(MapFeatureClickEvent.class, listener);
220217
}
221218

222-
/**
223-
* Checks whether the map component feature flag is active. Succeeds if the
224-
* flag is enabled, and throws otherwise.
225-
*
226-
* @throws ExperimentalFeatureException
227-
* when the {@link FeatureFlags#MAP_COMPONENT} feature is not
228-
* enabled
229-
*/
230-
private void checkFeatureFlag() {
231-
boolean enabled = getFeatureFlags()
232-
.isEnabled(FeatureFlags.MAP_COMPONENT);
233-
234-
if (!enabled) {
235-
throw new ExperimentalFeatureException();
236-
}
237-
}
238-
239-
/**
240-
* Gets the feature flags for the current UI.
241-
* <p>
242-
* Extracted with protected visibility to support mocking
243-
*
244-
* @return the current set of feature flags
245-
*/
246-
protected FeatureFlags getFeatureFlags() {
247-
return FeatureFlags
248-
.get(UI.getCurrent().getSession().getService().getContext());
249-
}
250-
251219
/**
252220
* Adds theme variants to the component.
253221
*

‎vaadin-map-flow-parent/vaadin-map-flow/src/test/java/com/vaadin/flow/component/map/FeatureFlagTest.java‎

Lines changed: 0 additions & 53 deletions
This file was deleted.

0 commit comments

Comments
 (0)