Skip to content

Commit fc7dc89

Browse files
authored
feat: notification warning variant (#5065)
* Adds enum for Warning variant * Adds warning variant to test view
1 parent 3381eb6 commit fc7dc89

2 files changed

Lines changed: 25 additions & 1 deletion

File tree

  • vaadin-notification-flow-parent

‎vaadin-notification-flow-parent/vaadin-notification-flow-integration-tests/src/main/java/com/vaadin/flow/component/notification/tests/NotificationView.java‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ private void createThemeVariants() {
134134
createContrast();
135135
createSuccess();
136136
createError();
137+
createWarning();
137138
}
138139

139140
private void createDefault() {
@@ -252,6 +253,29 @@ private void createError() {
252253
addCard("Theme Variants", "Error", openButton);
253254
}
254255

256+
private void createWarning() {
257+
Notification notification = new Notification();
258+
notification.addThemeVariants(NotificationVariant.LUMO_WARNING);
259+
260+
Span label = new Span("Warning about something!");
261+
262+
Button thisIsFineButton = new Button("This is fine",
263+
e -> notification.close());
264+
265+
Button investigateButton = new Button("Investigate",
266+
e -> notification.close());
267+
investigateButton.addThemeVariants(ButtonVariant.LUMO_PRIMARY);
268+
269+
notification.add(label, thisIsFineButton, investigateButton);
270+
271+
Button openButton = new Button("Warning notification",
272+
e -> notification.open());
273+
274+
label.getStyle().set("margin-right", "0.5rem");
275+
thisIsFineButton.getStyle().set("margin-right", "0.5rem");
276+
addCard("Theme Variants", "Warning", openButton);
277+
}
278+
255279
private void addCard(String title, Component... components) {
256280
addCard(title, null, components);
257281
}

‎vaadin-notification-flow-parent/vaadin-notification-flow/src/main/java/com/vaadin/flow/component/notification/NotificationVariant.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
*/
2323
public enum NotificationVariant implements ThemeVariant {
2424
LUMO_PRIMARY("primary"), LUMO_CONTRAST("contrast"), LUMO_SUCCESS(
25-
"success"), LUMO_ERROR("error");
25+
"success"), LUMO_ERROR("error"), LUMO_WARNING("warning");
2626

2727
private final String variant;
2828

0 commit comments

Comments
 (0)