Skip to content

DO NOT MERGE: bump version to 21.0.0-alpha0.b163d3a8c - #928

Closed
web-padawan wants to merge 2 commits into
masterfrom
canary-21.0.0-alpha0.b163d3a8c
Closed

web-padawan wants to merge 2 commits into
masterfrom
canary-21.0.0-alpha0.b163d3a8c

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

This is a PR for testing the 21.0.0-b163d3a8c and it is only to trigger validation build.

I will check any failures and update the code accordingly.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

SonarQube analysis reported 212 issues

  • CRITICAL 46 critical
  • MAJOR 32 major
  • MINOR 123 minor
  • INFO 11 info

Top 10 issues

  1. CRITICAL AvatarGroup.java#L395: Define a constant instead of duplicating this literal "The translation should not be null" 3 times. rule
  2. CRITICAL GeneratedVaadinCheckbox.java#L226: Define a constant instead of duplicating this literal "indeterminate" 3 times. rule
  3. CRITICAL GeneratedVaadinCheckbox.java#L287: Define a constant instead of duplicating this literal "checked" 5 times. rule
  4. CRITICAL GeneratedVaadinCheckboxGroup.java#L297: Define a constant instead of duplicating this literal "invalid" 3 times. rule
  5. CRITICAL GeneratedVaadinCheckboxGroup.java#L384: Define a constant instead of duplicating this literal "value" 4 times. rule
  6. CRITICAL GeneratedVaadinComboBox.java#L428: Define a constant instead of duplicating this literal "opened" 3 times. rule
  7. CRITICAL GeneratedVaadinComboBox.java#L621: Define a constant instead of duplicating this literal "filter" 3 times. rule
  8. CRITICAL GeneratedVaadinComboBox.java#L654: Define a constant instead of duplicating this literal "selectedItem" 3 times. rule
  9. CRITICAL GeneratedVaadinComboBox.java#L858: Define a constant instead of duplicating this literal "invalid" 3 times. rule
  10. CRITICAL GeneratedVaadinComboBox.java#L1421: Define a constant instead of duplicating this literal "value" 4 times. rule

@web-padawan

Copy link
Copy Markdown
Member Author

There is a failure related to lit-element warning:

java.lang.AssertionError: Expected only [Deprecation] warnings in the logs
Expected: a string containing "HTML Imports"
but: was "http://172.16.1.158:8080/VAADIN/build/vaadin-1-5c4cf9d0b115ce6d64e2.cache.js 517:8 "The main 'lit-element' module entrypoint is deprecated. Please update your imports to use the 'lit' package: 'lit' and 'lit/decorators.ts' or import from 'lit-element/lit-element.ts'.""
java.lang.AssertionError:
Expected only [Deprecation] warnings in the logs
Expected: a string containing "HTML Imports"
but: was "http://172.16.1.158:8080/VAADIN/build/vaadin-1-5c4cf9d0b115ce6d64e2.cache.js 517:8 "The main 'lit-element' module entrypoint is deprecated. Please update your imports to use the 'lit' package: 'lit' and 'lit/decorators.ts' or import from 'lit-element/lit-element.ts'.""

It's not related to web components though, so the import is probably elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants