Skip to content

Commit 0f146c2

Browse files
vaadin-botcaalador
andauthored
fix: check binding not binder status (#23093) (#23097) (#23102)
Check the correct statuses for non null. Fixes #23081 Co-authored-by: caalador <mikael.grankvist@vaadin.com>
1 parent 7b6d9da commit 0f146c2

2 files changed

Lines changed: 12 additions & 1 deletion

File tree

‎flow-data/src/main/java/com/vaadin/flow/data/binder/BinderValidationStatus.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public class BinderValidationStatus<BEAN> implements Serializable {
6262
public BinderValidationStatus(Binder<BEAN> source,
6363
List<BindingValidationStatus<?>> bindingStatuses,
6464
List<ValidationResult> binderStatuses) {
65-
Objects.requireNonNull(binderStatuses,
65+
Objects.requireNonNull(bindingStatuses,
6666
"binding statuses cannot be null");
6767
Objects.requireNonNull(binderStatuses,
6868
"binder statuses cannot be null");

‎flow-data/src/test/java/com/vaadin/flow/data/binder/BinderValidationStatusTest.java‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
*/
99
package com.vaadin.flow.data.binder;
1010

11+
import java.util.Collections;
1112
import java.util.HashMap;
1213
import java.util.List;
1314
import java.util.Map;
@@ -473,4 +474,14 @@ private void assertVisible(TestLabel label, boolean visible) {
473474
}
474475
}
475476

477+
@Test
478+
public void binderValidationStatus_nullBindingStatuses() {
479+
try {
480+
new BinderValidationStatus<>(new Binder<Person>(), null,
481+
Collections.emptyList());
482+
Assert.fail("Binder should throw an NPE");
483+
} catch (NullPointerException npe) {
484+
Assert.assertNotNull(npe.getMessage());
485+
}
486+
}
476487
}

0 commit comments

Comments
 (0)