Skip to content

Commit 1af40c6

Browse files
authored
fix: Do not append a nonsense slot to exported web components (#13473)
Fixes #9899
1 parent 54dcb48 commit 1af40c6

3 files changed

Lines changed: 1 addition & 6 deletions

File tree

‎flow-server/src/main/resources/com/vaadin/flow/server/webcomponent/webcomponent-script-template.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ _ThemeImport_class _TagCamel_ extends HTMLElement {
1313
}
1414
`;
1515
_ApplyTheme_shadow.appendChild(style);
16-
shadow.appendChild(document.createElement("slot"));
1716

1817
var self = this;
1918
/* Set initial property values from attributes */

‎flow-tests/test-embedding/embedding-test-assets/src/main/java/com/vaadin/flow/webcomponent/servlets/AbstractPlainServlet.java‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ protected void doGet(HttpServletRequest req, HttpServletResponse response)
3939
getImportsWriter().accept(out);
4040
out.println("<title>Embedded web component</title></head>");
4141
out.println("<body>");
42-
out.println(
43-
"<client-select show='true'>Web Component</client-select>");
42+
out.println("<client-select show='true'></client-select>");
4443
out.println("</body>");
4544
out.println("</html>");
4645
}

‎flow-tests/test-embedding/embedding-test-assets/src/test/java/com/vaadin/flow/webcomponent/EmbeddedWebComponentIT.java‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@ public void servletPageGetsWebComponent_attributeIsReflectedToServer() {
4141

4242
TestBenchElement webComponent = $("client-select").first();
4343

44-
Assert.assertTrue(
45-
webComponent.getText().trim().startsWith("Web Component"));
46-
4744
// Selection is visibly changed and event manually dispatched
4845
// as else the change is not seen.
4946
getCommandExecutor().executeScript(

0 commit comments

Comments
 (0)