|
22 | 22 | import java.util.concurrent.atomic.AtomicInteger; |
23 | 23 |
|
24 | 24 | import org.junit.jupiter.api.Test; |
| 25 | +import org.mockito.Mockito; |
25 | 26 |
|
| 27 | +import com.vaadin.flow.component.UI; |
| 28 | +import com.vaadin.flow.internal.CurrentInstance; |
| 29 | +import com.vaadin.flow.server.VaadinRequest; |
26 | 30 | import com.vaadin.flow.shared.Registration; |
27 | 31 | import com.vaadin.flow.signals.MissingSignalUsageException; |
28 | 32 | import com.vaadin.flow.signals.Signal; |
29 | 33 | import com.vaadin.flow.signals.SignalTestBase; |
30 | 34 | import com.vaadin.flow.signals.TestUtil; |
31 | 35 | import com.vaadin.flow.signals.impl.UsageTracker.Usage; |
| 36 | +import com.vaadin.flow.signals.local.ValueSignal; |
32 | 37 | import com.vaadin.flow.signals.shared.SharedListSignal; |
33 | 38 | import com.vaadin.flow.signals.shared.SharedMapSignal; |
34 | 39 | import com.vaadin.flow.signals.shared.SharedValueSignal; |
35 | 40 | import com.vaadin.flow.signals.shared.SharedValueSignalTest.AsyncSharedValueSignal; |
36 | 41 |
|
37 | 42 | import static org.junit.jupiter.api.Assertions.assertEquals; |
| 43 | +import static org.junit.jupiter.api.Assertions.assertFalse; |
38 | 44 | import static org.junit.jupiter.api.Assertions.assertThrows; |
| 45 | +import static org.junit.jupiter.api.Assertions.assertTrue; |
39 | 46 |
|
40 | 47 | class EffectTest extends SignalTestBase { |
41 | 48 |
|
@@ -774,4 +781,124 @@ public Registration onNextChange( |
774 | 781 | dispatcher.runPendingTasks(); |
775 | 782 | assertEquals(List.of("signal", "update"), invocations); |
776 | 783 | } |
| 784 | + |
| 785 | + @Test |
| 786 | + void ownerUI_sameUICurrent_notBackgroundChange() { |
| 787 | + UI ui = Mockito.mock(UI.class); |
| 788 | + UI.setCurrent(ui); |
| 789 | + |
| 790 | + ValueSignal<String> signal = new ValueSignal<>("hello"); |
| 791 | + List<Boolean> backgroundChanges = new ArrayList<>(); |
| 792 | + |
| 793 | + Effect effect = new Effect(ctx -> { |
| 794 | + signal.get(); |
| 795 | + backgroundChanges.add(ctx.isBackgroundChange()); |
| 796 | + }, Runnable::run); |
| 797 | + effect.setOwnerUI(ui); |
| 798 | + |
| 799 | + assertEquals(1, backgroundChanges.size()); |
| 800 | + assertFalse(backgroundChanges.get(0)); |
| 801 | + |
| 802 | + signal.set("update"); |
| 803 | + |
| 804 | + assertEquals(2, backgroundChanges.size()); |
| 805 | + assertFalse(backgroundChanges.get(1), |
| 806 | + "Change with same UI should not be background"); |
| 807 | + } |
| 808 | + |
| 809 | + @Test |
| 810 | + void ownerUI_noUICurrent_isBackgroundChange() { |
| 811 | + UI ui = Mockito.mock(UI.class); |
| 812 | + UI.setCurrent(ui); |
| 813 | + |
| 814 | + ValueSignal<String> signal = new ValueSignal<>("hello"); |
| 815 | + List<Boolean> backgroundChanges = new ArrayList<>(); |
| 816 | + |
| 817 | + Effect effect = new Effect(ctx -> { |
| 818 | + signal.get(); |
| 819 | + backgroundChanges.add(ctx.isBackgroundChange()); |
| 820 | + }, Runnable::run); |
| 821 | + effect.setOwnerUI(ui); |
| 822 | + |
| 823 | + assertEquals(1, backgroundChanges.size()); |
| 824 | + |
| 825 | + UI.setCurrent(null); |
| 826 | + signal.set("from background"); |
| 827 | + |
| 828 | + assertEquals(2, backgroundChanges.size()); |
| 829 | + assertTrue(backgroundChanges.get(1), |
| 830 | + "Change without UI should be background"); |
| 831 | + } |
| 832 | + |
| 833 | + @Test |
| 834 | + void ownerUI_differentUICurrent_isBackgroundChange() { |
| 835 | + UI uiA = Mockito.mock(UI.class); |
| 836 | + UI uiB = Mockito.mock(UI.class); |
| 837 | + |
| 838 | + ValueSignal<String> signal = new ValueSignal<>("initial"); |
| 839 | + List<Boolean> backgroundChangesA = new ArrayList<>(); |
| 840 | + List<Boolean> backgroundChangesB = new ArrayList<>(); |
| 841 | + |
| 842 | + UI.setCurrent(uiA); |
| 843 | + Effect effectA = new Effect(ctx -> { |
| 844 | + signal.get(); |
| 845 | + backgroundChangesA.add(ctx.isBackgroundChange()); |
| 846 | + }, Runnable::run); |
| 847 | + effectA.setOwnerUI(uiA); |
| 848 | + |
| 849 | + UI.setCurrent(uiB); |
| 850 | + Effect effectB = new Effect(ctx -> { |
| 851 | + signal.get(); |
| 852 | + backgroundChangesB.add(ctx.isBackgroundChange()); |
| 853 | + }, Runnable::run); |
| 854 | + effectB.setOwnerUI(uiB); |
| 855 | + |
| 856 | + assertEquals(1, backgroundChangesA.size()); |
| 857 | + assertEquals(1, backgroundChangesB.size()); |
| 858 | + |
| 859 | + // User A modifies the signal |
| 860 | + UI.setCurrent(uiA); |
| 861 | + signal.set("from user A"); |
| 862 | + |
| 863 | + assertEquals(2, backgroundChangesA.size()); |
| 864 | + assertFalse(backgroundChangesA.get(1), |
| 865 | + "Change from own UI should not be background"); |
| 866 | + |
| 867 | + assertEquals(2, backgroundChangesB.size()); |
| 868 | + assertTrue(backgroundChangesB.get(1), |
| 869 | + "Change from another UI should be background"); |
| 870 | + } |
| 871 | + |
| 872 | + @Test |
| 873 | + void noOwnerUI_fallsBackToVaadinRequestCheck() { |
| 874 | + VaadinRequest mockRequest = Mockito.mock(VaadinRequest.class); |
| 875 | + CurrentInstance.set(VaadinRequest.class, mockRequest); |
| 876 | + |
| 877 | + ValueSignal<String> signal = new ValueSignal<>("hello"); |
| 878 | + List<Boolean> backgroundChanges = new ArrayList<>(); |
| 879 | + |
| 880 | + // Effect without ownerUI (like Signal.unboundEffect) |
| 881 | + new Effect(ctx -> { |
| 882 | + signal.get(); |
| 883 | + backgroundChanges.add(ctx.isBackgroundChange()); |
| 884 | + }, Runnable::run); |
| 885 | + |
| 886 | + assertEquals(1, backgroundChanges.size()); |
| 887 | + assertFalse(backgroundChanges.get(0)); |
| 888 | + |
| 889 | + // Change with VaadinRequest present — not background |
| 890 | + signal.set("with request"); |
| 891 | + |
| 892 | + assertEquals(2, backgroundChanges.size()); |
| 893 | + assertFalse(backgroundChanges.get(1), |
| 894 | + "Change with VaadinRequest should not be background"); |
| 895 | + |
| 896 | + // Clear VaadinRequest — background |
| 897 | + CurrentInstance.set(VaadinRequest.class, null); |
| 898 | + signal.set("without request"); |
| 899 | + |
| 900 | + assertEquals(3, backgroundChanges.size()); |
| 901 | + assertTrue(backgroundChanges.get(2), |
| 902 | + "Change without VaadinRequest should be background"); |
| 903 | + } |
777 | 904 | } |
0 commit comments