Skip to content

Commit 48cc8be

Browse files
authored
fix: handle exception from BrowserLiveReloadAccessor (#19132)
Updates PushHandler to catch and log debug message of IllegalStateException from BrowserLiveReloadAccessor when it's thrown from already closed Spring context. Fixes: #18835
1 parent 68a1ead commit 48cc8be

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

‎flow-server/src/main/java/com/vaadin/flow/server/communication/PushHandler.java‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,8 +390,14 @@ private VaadinSession handleConnectionLost(AtmosphereResourceEvent event) {
390390
// In development mode we may have a live-reload push channel
391391
// that should be closed.
392392

393-
Optional<BrowserLiveReload> liveReload = BrowserLiveReloadAccessor
394-
.getLiveReloadFromService(service);
393+
Optional<BrowserLiveReload> liveReload = Optional.empty();
394+
try {
395+
liveReload = BrowserLiveReloadAccessor
396+
.getLiveReloadFromService(service);
397+
} catch (IllegalStateException e) {
398+
getLogger().debug(
399+
"Could not get live-reload push channel to close it.", e);
400+
}
395401
if (isDebugWindowConnection(resource) && liveReload.isPresent()
396402
&& liveReload.get().isLiveReload(resource)) {
397403
liveReload.get().onDisconnect(resource);

0 commit comments

Comments
 (0)