Repository navigation
Commit 4e36fd9
authored
fix: Ensure that side effects of readBean do not set hasChanges true (#12181)
JavaDoc of hasChanges says:
"Check whether any of the bound fields' have uncommitted changes
since last explicit call to readBean(Object), removeBean(), writeBean(Object)}
or writeBeanIfValid(Object)."
If readBean has converters, they will be run and field values updated accordingly.
Furthermore if fields have value change listeners that will produce further
changes in values, this should be considered according to above as part of
readBean procedure and thus hasChanges still should return false.
Cherry pick from: vaadin/framework#124551 parent ad39b06 commit 4e36fd9
2 files changed
Lines changed: 24 additions & 1 deletion
File tree
- flow-data/src
- main/java/com/vaadin/flow/data/binder
- test/java/com/vaadin/flow/data/binder
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2101 | 2101 | | |
2102 | 2102 | | |
2103 | 2103 | | |
2104 | | - | |
2105 | 2104 | | |
2106 | 2105 | | |
2107 | 2106 | | |
| |||
2113 | 2112 | | |
2114 | 2113 | | |
2115 | 2114 | | |
| 2115 | + | |
2116 | 2116 | | |
2117 | 2117 | | |
2118 | 2118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1968 | 1968 | | |
1969 | 1969 | | |
1970 | 1970 | | |
| 1971 | + | |
| 1972 | + | |
| 1973 | + | |
| 1974 | + | |
| 1975 | + | |
| 1976 | + | |
| 1977 | + | |
| 1978 | + | |
| 1979 | + | |
| 1980 | + | |
| 1981 | + | |
| 1982 | + | |
| 1983 | + | |
| 1984 | + | |
| 1985 | + | |
| 1986 | + | |
| 1987 | + | |
| 1988 | + | |
| 1989 | + | |
| 1990 | + | |
| 1991 | + | |
| 1992 | + | |
| 1993 | + | |
1971 | 1994 | | |
1972 | 1995 | | |
1973 | 1996 | | |
| |||
0 commit comments