Repository navigation
Commit 72d62c2
authored
fix: sync property change properly using debouncer (#17971)
* fix: sync property change properly using debouncer
Fixes `Element#addPropertyChangeListener(String, String, PropertyChangeListener)` using `debounce(int)` to synchronize changed property value to the server even when explicitly firing more than one event in a row, while still being inside the debounce timeout time window.
Previously, following events caused the first property change command to never run because the first command was cancelled in favor for the new command. New command is always a NO_OP due to the property not being changed again in this use case (#17931, it was detected as changed already for the first command). This change has effect only when using TRAILING debounce phase (default).
Fixes: #17931
* Keeping intermediate phase working the same it was
* Fixed formatting
* Added test for multiple events and value changes
---------1 parent a959c6c commit 72d62c2
6 files changed
Lines changed: 174 additions & 50 deletions
File tree
- flow-client/src
- main/java/com/vaadin/client/flow
- binding
- nodefeature
- test-gwt/java/com/vaadin/client/flow
- flow-tests/test-root-context/src
- main/java/com/vaadin/flow/uitest/ui
- test/java/com/vaadin/flow/uitest/ui
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
47 | 48 | | |
48 | 49 | | |
49 | 50 | | |
50 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
51 | 54 | | |
| 55 | + | |
52 | 56 | | |
53 | 57 | | |
54 | 58 | | |
| |||
65 | 69 | | |
66 | 70 | | |
67 | 71 | | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
68 | 76 | | |
69 | 77 | | |
70 | 78 | | |
71 | | - | |
| 79 | + | |
| 80 | + | |
72 | 81 | | |
73 | 82 | | |
74 | 83 | | |
| |||
79 | 88 | | |
80 | 89 | | |
81 | 90 | | |
82 | | - | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
83 | 98 | | |
| 99 | + | |
84 | 100 | | |
85 | 101 | | |
86 | 102 | | |
| |||
89 | 105 | | |
90 | 106 | | |
91 | 107 | | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
96 | 115 | | |
97 | 116 | | |
98 | 117 | | |
| |||
103 | 122 | | |
104 | 123 | | |
105 | 124 | | |
106 | | - | |
107 | | - | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
108 | 129 | | |
109 | | - | |
| 130 | + | |
110 | 131 | | |
111 | 132 | | |
112 | 133 | | |
| |||
119 | 140 | | |
120 | 141 | | |
121 | 142 | | |
122 | | - | |
123 | | - | |
124 | | - | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
125 | 146 | | |
126 | | - | |
| 147 | + | |
| 148 | + | |
127 | 149 | | |
128 | | - | |
| 150 | + | |
| 151 | + | |
129 | 152 | | |
130 | 153 | | |
131 | 154 | | |
| |||
138 | 161 | | |
139 | 162 | | |
140 | 163 | | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
141 | 188 | | |
142 | 189 | | |
143 | 190 | | |
| |||
223 | 270 | | |
224 | 271 | | |
225 | 272 | | |
226 | | - | |
| 273 | + | |
227 | 274 | | |
228 | 275 | | |
229 | | - | |
230 | | - | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
231 | 279 | | |
232 | 280 | | |
233 | 281 | | |
| |||
237 | 285 | | |
238 | 286 | | |
239 | 287 | | |
240 | | - | |
241 | | - | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
242 | 291 | | |
243 | 292 | | |
244 | 293 | | |
245 | 294 | | |
246 | 295 | | |
247 | 296 | | |
248 | | - | |
249 | | - | |
| 297 | + | |
| 298 | + | |
250 | 299 | | |
251 | | - | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
252 | 303 | | |
253 | 304 | | |
254 | 305 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| |||
1299 | 1300 | | |
1300 | 1301 | | |
1301 | 1302 | | |
1302 | | - | |
1303 | | - | |
1304 | | - | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
1305 | 1306 | | |
1306 | 1307 | | |
1307 | | - | |
1308 | | - | |
1309 | 1308 | | |
1310 | 1309 | | |
1311 | 1310 | | |
1312 | 1311 | | |
1313 | | - | |
| 1312 | + | |
1314 | 1313 | | |
1315 | 1314 | | |
1316 | 1315 | | |
| |||
1326 | 1325 | | |
1327 | 1326 | | |
1328 | 1327 | | |
| 1328 | + | |
1329 | 1329 | | |
1330 | 1330 | | |
1331 | 1331 | | |
| |||
1356 | 1356 | | |
1357 | 1357 | | |
1358 | 1358 | | |
1359 | | - | |
| 1359 | + | |
1360 | 1360 | | |
1361 | 1361 | | |
1362 | 1362 | | |
| |||
1378 | 1378 | | |
1379 | 1379 | | |
1380 | 1380 | | |
1381 | | - | |
| 1381 | + | |
1382 | 1382 | | |
1383 | 1383 | | |
1384 | 1384 | | |
| |||
1388 | 1388 | | |
1389 | 1389 | | |
1390 | 1390 | | |
1391 | | - | |
| 1391 | + | |
| 1392 | + | |
1392 | 1393 | | |
1393 | 1394 | | |
1394 | 1395 | | |
| |||
1408 | 1409 | | |
1409 | 1410 | | |
1410 | 1411 | | |
1411 | | - | |
| 1412 | + | |
1412 | 1413 | | |
1413 | 1414 | | |
1414 | 1415 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
46 | | - | |
| 46 | + | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
201 | 207 | | |
202 | 208 | | |
203 | 209 | | |
204 | 210 | | |
205 | 211 | | |
206 | | - | |
207 | | - | |
| 212 | + | |
| 213 | + | |
208 | 214 | | |
209 | 215 | | |
210 | 216 | | |
| |||
219 | 225 | | |
220 | 226 | | |
221 | 227 | | |
222 | | - | |
| 228 | + | |
223 | 229 | | |
224 | 230 | | |
| 231 | + | |
| 232 | + | |
225 | 233 | | |
226 | 234 | | |
227 | 235 | | |
228 | | - | |
| 236 | + | |
229 | 237 | | |
230 | 238 | | |
231 | 239 | | |
| |||
235 | 243 | | |
236 | 244 | | |
237 | 245 | | |
| 246 | + | |
| 247 | + | |
| 248 | + | |
| 249 | + | |
| 250 | + | |
| 251 | + | |
238 | 252 | | |
239 | 253 | | |
240 | 254 | | |
241 | 255 | | |
242 | 256 | | |
243 | | - | |
244 | | - | |
| 257 | + | |
| 258 | + | |
245 | 259 | | |
246 | 260 | | |
247 | 261 | | |
| |||
254 | 268 | | |
255 | 269 | | |
256 | 270 | | |
257 | | - | |
| 271 | + | |
258 | 272 | | |
259 | 273 | | |
260 | | - | |
261 | | - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
262 | 277 | | |
263 | 278 | | |
264 | 279 | | |
265 | | - | |
| 280 | + | |
266 | 281 | | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
271 | 286 | | |
272 | 287 | | |
273 | 288 | | |
| |||
278 | 293 | | |
279 | 294 | | |
280 | 295 | | |
281 | | - | |
| 296 | + | |
282 | 297 | | |
283 | 298 | | |
284 | 299 | | |
| |||
0 commit comments