Repository navigation
Commit 7f45171
authored
fix: skip validation on signal effect initial run in Binder (#23749)
The reactive signal effect created by initInternalSignalEffectForValidators()
was firing validation on its initial run when deferred to component attach,
causing required fields to be marked invalid immediately on navigation.
Use the context-aware Signal.effect() variant and skip fireValidationEvents
on the initial run, so validation only triggers on actual value changes.
Fixes vaadin/flow-components#88411 parent 08d70e4 commit 7f45171
2 files changed
Lines changed: 14 additions & 2 deletions
File tree
- flow-data/src
- main/java/com/vaadin/flow/data/binder
- test/java/com/vaadin/flow/data/binder
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1731 | 1731 | | |
1732 | 1732 | | |
1733 | 1733 | | |
1734 | | - | |
| 1734 | + | |
1735 | 1735 | | |
1736 | 1736 | | |
1737 | | - | |
| 1737 | + | |
1738 | 1738 | | |
1739 | 1739 | | |
1740 | 1740 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
956 | 956 | | |
957 | 957 | | |
958 | 958 | | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
959 | 971 | | |
0 commit comments