Skip to content

Commit 7f45171

Browse files
authored
fix: skip validation on signal effect initial run in Binder (#23749)
The reactive signal effect created by initInternalSignalEffectForValidators() was firing validation on its initial run when deferred to component attach, causing required fields to be marked invalid immediately on navigation. Use the context-aware Signal.effect() variant and skip fireValidationEvents on the initial run, so validation only triggers on actual value changes. Fixes vaadin/flow-components#8841
1 parent 08d70e4 commit 7f45171

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

‎flow-data/src/main/java/com/vaadin/flow/data/binder/Binder.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1731,10 +1731,10 @@ && getField() instanceof Component component) {
17311731
// Satisfies the signal usage requirement for bindings
17321732
// without signal-using validators in the chain.
17331733
var usageGuard = new ValueSignal<Void>(null);
1734-
signalRegistration = Signal.effect(component, () -> {
1734+
signalRegistration = Signal.effect(component, ctx -> {
17351735
usageGuard.get();
17361736
Result<TARGET> result = executeConversionChain();
1737-
if (!valueInit) {
1737+
if (!ctx.isInitialRun()) {
17381738
BindingValidationStatus<TARGET> status = toValidationStatus(
17391739
result);
17401740
fireValidationEvents(status);

‎flow-data/src/test/java/com/vaadin/flow/data/binder/BinderSignalTest.java‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -956,4 +956,16 @@ private void testInitialStatusChangeRunEffects(
956956
binderSetup.accept(person);
957957
assertFalse(prevStatus.get());
958958
}
959+
960+
@Test
961+
public void asRequired_setBeanBeforeBind_fieldNotInvalidOnAttach() {
962+
var field = new TestTextField();
963+
binder.setBean(item);
964+
binder.forField(field).asRequired("Required field")
965+
.bind(Person::getFirstName, Person::setFirstName);
966+
967+
UI.getCurrent().add(field);
968+
969+
assertFalse(field.isInvalid());
970+
}
959971
}

0 commit comments

Comments
 (0)