Skip to content

Commit 813dd86

Browse files
author
Denis
authored
fix: format numbers in NumberRenderer using Locale if it's provided (#11373)
fixes #8970
1 parent c855a15 commit 813dd86

2 files changed

Lines changed: 43 additions & 1 deletion

File tree

‎flow-data/src/main/java/com/vaadin/flow/data/renderer/NumberRenderer.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public NumberRenderer(ValueProvider<SOURCE, Number> valueProvider,
114114
*/
115115
public NumberRenderer(ValueProvider<SOURCE, Number> valueProvider,
116116
Locale locale) {
117-
this(valueProvider, "%s", locale);
117+
this(valueProvider, NumberFormat.getInstance(locale));
118118
}
119119

120120
/**
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
/*
2+
* Copyright 2000-2021 Vaadin Ltd.
3+
*
4+
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
5+
* use this file except in compliance with the License. You may obtain a copy of
6+
* the License at
7+
*
8+
* http://www.apache.org/licenses/LICENSE-2.0
9+
*
10+
* Unless required by applicable law or agreed to in writing, software
11+
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
12+
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
13+
* License for the specific language governing permissions and limitations under
14+
* the License.
15+
*/
16+
package com.vaadin.flow.data.renderer;
17+
18+
import java.util.Locale;
19+
20+
import org.junit.Assert;
21+
import org.junit.Test;
22+
23+
import com.vaadin.flow.function.ValueProvider;
24+
25+
public class NumberRendererTest {
26+
27+
@Test
28+
public void getFormattedValue_numberIsFormattedUsingLocale() {
29+
NumberRenderer<Number> renderer = new NumberRenderer<>(
30+
ValueProvider.identity(), Locale.GERMANY);
31+
32+
String formatted = renderer.getFormattedValue(1.2);
33+
Assert.assertEquals("1,2", formatted);
34+
35+
renderer = new NumberRenderer<>(ValueProvider.identity(),
36+
Locale.ENGLISH);
37+
38+
formatted = renderer.getFormattedValue(1.2);
39+
Assert.assertEquals("1.2", formatted);
40+
}
41+
42+
}

0 commit comments

Comments
 (0)