You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 90e7fa9
Browse filesBrowse the repository at this point in the historyBrowse files
authored
fix: Allow Gradle builds to use custom sourcesets (#15739) (CP: 23.3) (#15753)
* fix: Allow Gradle builds to use custom sourcesets (#15739)
When a sourceset other than `main` is used for holding classes using
Vaadin components, or for providing a resolution scope for Vaadin
dependencies, the `prepareVaadinFrontend` task does not correctly
extract the correct Node libraries required by those classes, and the
`buildVaadinFrontend` task subsequently fails to complete due to Vite
requiring those Node dependencies to have been extracted into the
project so failing to find all of its front-end dependencies.
The `VaadinFlowPluginExtension` is being altered to include a
`sourceSetName` field, that defaults to `main` for backwards
compatibility but allows users to specify a custom sourceset to use for
the prepare and build tasks. As the use of a custom sourceset generally
implies that different Gradle tasks will be executed for operating on
those sourcesets, and a different dependency scope generated for the
custom sourceset, fields have also been added to the extension that
allow users to override the values the plugin uses, whilst the default
values follow the Gradle conventions for both `main` and non-`main`
sourcesets.
Fixes#15738
* downgrade spring boot version
Co-authored-by: Michael Clarke <mc1arke@users.noreply.github.com>
Co-authored-by: Marco Collovati <marco@vaadin.com>
@@ -33,17 +31,18 @@ public open class VaadinPrepareFrontendTask : DefaultTask() {
33
31
group ="Vaadin"
34
32
description ="checks that node and npm tools are installed, copies frontend resources available inside `.jar` dependencies to `node_modules`, and creates or updates `package.json` and `webpack.config.json` files."
35
33
34
+
val extension:VaadinFlowPluginExtension=VaadinFlowPluginExtension.get(project)
36
35
// Maven's task run in the LifecyclePhase.PROCESS_RESOURCES phase
37
36
38
37
// the processResources copies stuff from build/vaadin-generated
39
38
// (which is populated by this task) and therefore must run after this task.
0 commit comments