Repository navigation
Commit 9e3d938
authored
fix: eager load css from CssImport.themeFor (#17408)
* fix: eager load css from CssImport.themeFor
CSS from CssImport.themeFor should be eagerly loaded, otherwise the framework
tries to apply them after the web-component is already registered, resulting
in an error in the browser.
Although CssImport.themeFor is not recommended with Vaadin 24 it can still be
used and in some cases it is required to work around some of the limitations
mentioned in vaadin/docs#2552.
This change forces CSS from CssImport.themeFor to be loaded eagerly.
Fixes #17345
Fixes #17221
* Apply review suggestions1 parent a108dae commit 9e3d938
2 files changed
Lines changed: 32 additions & 1 deletion
File tree
- flow-server/src
- main/java/com/vaadin/flow/server/frontend
- test/java/com/vaadin/flow/server/frontend
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | | - | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
180 | 182 | | |
181 | 183 | | |
182 | 184 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
90 | 96 | | |
91 | 97 | | |
92 | 98 | | |
| |||
460 | 466 | | |
461 | 467 | | |
462 | 468 | | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
| 472 | + | |
| 473 | + | |
| 474 | + | |
| 475 | + | |
| 476 | + | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
| 482 | + | |
| 483 | + | |
| 484 | + | |
| 485 | + | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
463 | 492 | | |
464 | 493 | | |
465 | 494 | | |
| |||
0 commit comments