Repository navigation
Commit fdbe642
authored
refactor!: Remove StaticFileHandler.isStaticResourceRequest (#12263)
This simplifies static file handling so the same logic is not duplicate in two places. It also makes it possible to always query the dev server for files instead of knowing upfront what the dev server can serve.
The method is removed instead of retained as there are two ways it could have been used:
1. Called to check if a given request is a static resource request
2. Overridden in a custom StaticFileHandler
To keep the method we would need to do the following for the cases:
1. Make isStaticResourceRequest return serveStaticResource() != null
2. Make serveStaticResource() call isStaticResourceRequest() as the first thing
We cannot do both so it is safer to remove the method to force code to be updated1 parent 2e9c915 commit fdbe642
10 files changed
Lines changed: 141 additions & 133 deletions
File tree
- flow-server/src
- main/java/com/vaadin/flow/server
- test/java/com/vaadin/flow/server
- flow-tests
- test-application-theme/test-theme-reusable/src/test/java/com/vaadin/flow/uitest/ui/theme
- test-dev-mode/src/test/java/com/vaadin/flow/uitest/ui
- test-pwa/src/test/java/com/vaadin/flow/pwatest/ui
- test-root-context/src/test/java/com/vaadin/flow
- test-themes/src/test/java/com/vaadin/flow/uitest/ui/theme
- vaadin-dev-server/src/main/java/com/vaadin/base/devserver
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | 35 | | |
46 | 36 | | |
47 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | 104 | | |
150 | 105 | | |
151 | 106 | | |
| |||
277 | 232 | | |
278 | 233 | | |
279 | 234 | | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
280 | 242 | | |
281 | 243 | | |
282 | 244 | | |
283 | | - | |
| 245 | + | |
284 | 246 | | |
285 | 247 | | |
286 | 248 | | |
287 | 249 | | |
288 | | - | |
289 | | - | |
290 | | - | |
291 | | - | |
| 250 | + | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
292 | 254 | | |
293 | 255 | | |
294 | 256 | | |
| |||
317 | 279 | | |
318 | 280 | | |
319 | 281 | | |
320 | | - | |
321 | | - | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
322 | 290 | | |
323 | 291 | | |
324 | 292 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
328 | 328 | | |
329 | 329 | | |
330 | 330 | | |
331 | | - | |
332 | | - | |
| 331 | + | |
333 | 332 | | |
334 | 333 | | |
335 | 334 | | |
| |||
0 commit comments