Skip to content

refactor: add theme editor license check - #16230

Closed
sissbruecker wants to merge 3 commits into
mainfrom
refactor/theme_editor_license_check
Closed

sissbruecker wants to merge 3 commits into
mainfrom
refactor/theme_editor_license_check

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Description

WIP

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   951 files  ±0     951 suites  ±0   57m 43s ⏱️ +44s
6 036 tests ±0  6 001 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
6 292 runs  +8  6 250 ✔️ +8  42 💤 ±0  0 ❌ ±0 

Results for commit 69c70cd. ± Comparison against base commit afb86c2.

`;
}

renderMissingLicenseNotice() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse messageHtml from License.ts? it's no point of duplicating same. It could also simplify handling of no license response.

@sissbruecker

Copy link
Copy Markdown
Member Author

Closing this for now, as the theme editor will stay behind a feature flag, and will be freely accessible until a stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants