Skip to content

Dropping logging level from warn to info - #9473

Closed
TatuLund wants to merge 4 commits into
masterfrom
fix8848
Closed

TatuLund wants to merge 4 commits into
masterfrom
fix8848

Conversation

@TatuLund

Copy link
Copy Markdown
Contributor

We have encountered real-life scenario, where these warnings pollutes logs in excessive manner. As it is normal conditions harmless note, it does not warrant warn level, I am proposing to change to debug level.

"Currently in our server production log, 80% is filled with this and we will have hard time monitoring our application."

Fixes: #8848

We have encountered real-life scenario, where these warnings pollutes logs in excessive manner. As it is normal conditions harmless note, it does not warrant warn level, I am proposing to change to debug level.

Fixes: #8848
@Legioth

Legioth commented Nov 23, 2020

Copy link
Copy Markdown
Member

If dropping the logging level, then maybe only one step to info instead? Those warnings can be highly relevant especially for someone debugging cases when their own component isn't updating the server as expected.

@pleku pleku left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, info is better than debug.
If someone is looking to cut down the amount of logs, info level is already too noisy for that.
And as this is still kind of a sign of some "extra communication" between client->server that is not necessary, one should be able to take note about it without setting the level to debug.

pleku
pleku previously approved these changes Nov 25, 2020
@vaadin-bot vaadin-bot added +0.1.0 and removed +0.0.1 labels Nov 25, 2020
@pleku pleku added +0.0.1 and removed +0.1.0 labels Dec 4, 2020
@pleku
pleku self-requested a review December 4, 2020 09:53
@pleku
pleku dismissed their stale review December 4, 2020 09:53

Seconds thoughts

@pleku

pleku commented Dec 7, 2020

Copy link
Copy Markdown

So after some investigation it would seem that the best thing to do would be to address any warnings that result from disabled Vaadin components individually - thus the warning level should stay there as it is not as intended. There is at least one case for TextField, NumberField, DataPicker, TimePicker BigDecimalField ... where it is just not working right and producing the warning because it is not working properly - and this should be fixed instead. Working on that at the moment and closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Property update request for disabled element warning when calling setEnabled(false)

4 participants