Repository navigation
feat: add support for custom formats to date picker - #1975
Merged
Merged
Conversation
* add some basic tests * add additional tests * fix formatting
sissbruecker
commented
Aug 2, 2021
knoobie
reviewed
Aug 2, 2021
sissbruecker
commented
Aug 2, 2021
sissbruecker
commented
Aug 2, 2021
fhdhsni
force-pushed
the
feat/date_picker_custom_formats
branch
from
August 2, 2021 19:34
2eb61c5 to
ccdb41f
Compare
…pdating I18N settings
sissbruecker
commented
Aug 3, 2021
sissbruecker
marked this pull request as ready for review
August 4, 2021 06:55
fhdhsni
approved these changes
Aug 4, 2021
Collaborator
|
SonarQube analysis reported 9 issues
|
Collaborator
|
This ticket/PR has been released with platform 22.0.0.alpha1 and is also targeting the upcoming stable 22.0.0 version. |
sissbruecker
added a commit
that referenced
this pull request
Aug 12, 2021
Added support for custom date formats to the Flow DatePicker component. The DatePickerI18N class now supports setting a custom date format that will be used for displaying dates and parsing user inputs. Optionally additional parsing formats can be specified to support entering dates in different formats. Co-authored-by: Farhad <farhad@vaadin.com> (cherry picked from commit 1c4ddf8)
1 of 2 tasks
sissbruecker
added a commit
that referenced
this pull request
Sep 9, 2021
* feat: add support for custom formats to date picker (#1975) Added support for custom date formats to the Flow DatePicker component. The DatePickerI18N class now supports setting a custom date format that will be used for displaying dates and parsing user inputs. Optionally additional parsing formats can be specified to support entering dates in different formats. Co-authored-by: Farhad <farhad@vaadin.com> (cherry picked from commit 1c4ddf8) * refactor: replace NpmPackage annotation with custom date-fns bundle * fix node dependency versions Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Adds support for custom date formats to the DatePicker by configuring the DatePickerI18n instance.
Fixes #911
Type of change
Checklist
Additional for
Featuretype of change