Skip to content

Commit 0341f1b

Browse files
authored
fix: validate on arrow keys when field has step (#6424)
1 parent 30a6204 commit 0341f1b

2 files changed

Lines changed: 24 additions & 0 deletions

File tree

‎packages/time-picker/src/vaadin-time-picker.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -471,6 +471,7 @@ class TimePicker extends PatternMixin(InputControlMixin(ThemableMixin(ElementMix
471471
const parsedObj = this.i18n.parseTime(this._comboBoxValue);
472472
const objWithStep = this.__addStep(this.__getMsec(parsedObj), step, true);
473473
this._comboBoxValue = this.i18n.formatTime(objWithStep);
474+
this.validate();
474475
this.__commitPendingValue();
475476
}
476477

‎packages/time-picker/test/validation.test.js‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import { expect } from '@esm-bundle/chai';
22
import { enter, fixtureSync, focusout, nextRender, outsideClick } from '@vaadin/testing-helpers';
3+
import { sendKeys } from '@web/test-runner-commands';
34
import sinon from 'sinon';
45
import { TimePicker } from '../src/vaadin-time-picker.js';
56
import { setInputValue } from './helpers.js';
@@ -191,6 +192,28 @@ describe('validation', () => {
191192
const event = validatedSpy.firstCall.args[0];
192193
expect(event.detail.valid).to.be.false;
193194
});
195+
196+
describe('with step', () => {
197+
beforeEach(() => {
198+
timePicker.step = 1;
199+
});
200+
201+
it('should validate before change event on ArrowDown', async () => {
202+
input.focus();
203+
await sendKeys({ press: 'ArrowDown' });
204+
expect(changeSpy).to.be.calledOnce;
205+
expect(validateSpy).to.be.calledOnce;
206+
expect(validateSpy).to.be.calledBefore(changeSpy);
207+
});
208+
209+
it('should validate before change event on ArrowUp', async () => {
210+
input.focus();
211+
await sendKeys({ press: 'ArrowUp' });
212+
expect(changeSpy).to.be.calledOnce;
213+
expect(validateSpy).to.be.calledOnce;
214+
expect(validateSpy).to.be.calledBefore(changeSpy);
215+
});
216+
});
194217
});
195218

196219
describe('input value', () => {

0 commit comments

Comments
 (0)