Skip to content

Commit 0cbdfdb

Browse files
authored
fix: allow null and undefined for errorMessage (#3066)
1 parent e135ed2 commit 0cbdfdb

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎packages/date-picker/test/typings/date-picker.types.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ assertType<boolean>(datePicker.invalid);
5959
assertType<HTMLElement | null | undefined>(datePicker.focusElement);
6060
assertType<boolean>(datePicker.disabled);
6161
assertType<boolean>(datePicker.clearButtonVisible);
62-
assertType<string>(datePicker.errorMessage);
62+
assertType<string | null | undefined>(datePicker.errorMessage);
6363
assertType<string>(datePicker.placeholder);
6464
assertType<string | null | undefined>(datePicker.helperText);
6565
assertType<boolean>(datePicker.readonly);

‎packages/date-time-picker/test/typings/date-time-picker.types.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ assertType<boolean>(picker.required);
1919
assertType<boolean>(picker.invalid);
2020
assertType<boolean>(picker.disabled);
2121
assertType<boolean>(picker.readonly);
22-
assertType<string>(picker.errorMessage);
22+
assertType<string | null | undefined>(picker.errorMessage);
2323
assertType<string>(picker.value);
2424
assertType<string | null | undefined>(picker.name);
2525
assertType<string | undefined>(picker.min);

‎packages/field-base/src/field-mixin.d.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ export declare class FieldMixinClass {
3333
helperText: string | null | undefined;
3434

3535
/**
36-
* Error to show when the field is invalid.
36+
* Error message to show when the field is invalid.
3737
*
3838
* @attr {string} error-message
3939
*/
40-
errorMessage: string;
40+
errorMessage: string | null | undefined;
4141

4242
protected readonly _ariaAttr: 'aria-labelledby' | 'aria-describedby';
4343

0 commit comments

Comments
 (0)