Skip to content

Commit 106fc4c

Browse files
authored
fix: use translate instead of margin for tree toggle (#4657)
1 parent 29a5515 commit 106fc4c

2 files changed

Lines changed: 31 additions & 1 deletion

File tree

‎packages/grid/test/column-auto-width.test.js‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,36 @@ describe('column auto-width', () => {
150150
});
151151
});
152152

153+
describe('tree column', () => {
154+
let grid;
155+
156+
beforeEach(() => {
157+
grid = fixtureSync(`
158+
<vaadin-grid>
159+
<vaadin-grid-tree-column auto-width path="name" flex-grow="0"></vaadin-grid-tree-column>
160+
</vaadin-grid>
161+
`);
162+
163+
const data = [
164+
{
165+
name: 'a',
166+
children: [
167+
{
168+
name: 'b',
169+
},
170+
],
171+
},
172+
];
173+
grid.dataProvider = (params, cb) => cb(params.parentItem ? params.parentItem.children : data, 1);
174+
grid.expandItem(data[0]);
175+
flushGrid(grid);
176+
});
177+
178+
it('should recalculate tree column width correctly', () => {
179+
expect(parseInt(grid.firstElementChild.width)).to.be.closeTo(107, 5);
180+
});
181+
});
182+
153183
describe('async recalculateWidth columns', () => {
154184
let grid;
155185

‎packages/grid/theme/lumo/vaadin-grid-tree-toggle-styles.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ registerStyles(
1010
--vaadin-grid-tree-toggle-level-offset: 2em;
1111
align-items: center;
1212
vertical-align: middle;
13-
margin-left: calc(var(--lumo-space-s) * -1);
13+
transform: translateX(calc(var(--lumo-space-s) * -1));
1414
-webkit-tap-highlight-color: transparent;
1515
}
1616

0 commit comments

Comments
 (0)