Skip to content

Commit 19aca5e

Browse files
authored
refactor: use once for editor cancel event listener (#4587)
1 parent 2d5c087 commit 19aca5e

1 file changed

Lines changed: 13 additions & 11 deletions

File tree

‎packages/crud/src/vaadin-crud.js‎

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1052,17 +1052,19 @@ class Crud extends SlotMixin(ControllerMixin(ElementMixin(ThemableMixin(PolymerE
10521052
this.editedItem !== item // Item is different
10531053
) {
10541054
this.$.confirmCancel.opened = true;
1055-
const listenOnce = (event) => {
1056-
event.preventDefault(); // Prevent editor to get closed
1057-
if (item || keepOpened) {
1058-
this.__edit(item);
1059-
this.__clearItemAndKeepEditorOpened(item, keepOpened);
1060-
} else {
1061-
this.__closeEditor();
1062-
}
1063-
this.removeEventListener('cancel', listenOnce);
1064-
};
1065-
this.addEventListener('cancel', listenOnce);
1055+
this.addEventListener(
1056+
'cancel',
1057+
(event) => {
1058+
event.preventDefault(); // Prevent closing the editor
1059+
if (item || keepOpened) {
1060+
this.__edit(item);
1061+
this.__clearItemAndKeepEditorOpened(item, keepOpened);
1062+
} else {
1063+
this.__closeEditor();
1064+
}
1065+
},
1066+
{ once: true },
1067+
);
10661068
} else {
10671069
this.__edit(item);
10681070
this.__clearItemAndKeepEditorOpened(item, keepOpened);

0 commit comments

Comments
 (0)