Skip to content

Commit 231af8d

Browse files
authored
fix: make row details renderer arguments required (#4917)
1 parent dc231ed commit 231af8d

2 files changed

Lines changed: 8 additions & 5 deletions

File tree

‎packages/grid/src/vaadin-grid-row-details-mixin.d.ts‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,7 @@
66
import type { Constructor } from '@open-wc/dedupe-mixin';
77
import type { Grid, GridItemModel } from './vaadin-grid.js';
88

9-
export type GridRowDetailsRenderer<TItem> = (
10-
root: HTMLElement,
11-
grid?: Grid<TItem>,
12-
model?: GridItemModel<TItem>,
13-
) => void;
9+
export type GridRowDetailsRenderer<TItem> = (root: HTMLElement, grid: Grid<TItem>, model: GridItemModel<TItem>) => void;
1410

1511
export declare function RowDetailsMixin<TItem, T extends Constructor<HTMLElement>>(
1612
base: T,

‎packages/grid/test/typings/grid.types.ts‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,13 @@ assertType<() => void>(narrowedGrid.filterDragAndDrop);
173173
assertType<(arg0: Event) => GridEventContext<TestGridItem>>(narrowedGrid.getEventContext);
174174

175175
assertType<GridRowDetailsRenderer<TestGridItem> | null | undefined>(narrowedGrid.rowDetailsRenderer);
176+
const rowDetailsRenderer: GridRowDetailsRenderer<TestGridItem> = (root, grid, model) => {
177+
assertType<HTMLElement>(root);
178+
assertType<Grid>(grid);
179+
assertType<TestGridItem>(model.item);
180+
};
181+
narrowedGrid.rowDetailsRenderer = rowDetailsRenderer;
182+
176183
assertType<(arg0: TestGridItem) => void>(narrowedGrid.openItemDetails);
177184
assertType<(arg0: TestGridItem) => void>(narrowedGrid.closeItemDetails);
178185
assertType<(arg0: number) => void>(narrowedGrid.scrollToIndex);

0 commit comments

Comments
 (0)