Repository navigation
Commit 28016d3
fix: mirror overflow chip stack and remove button in RTL (#12951)
## Description
Related to #12950
In RTL, the overflow chip of the multi-select combo box reserves space
for its stacked lines with `margin-inline-start`, but the lines were
offset with the physical `left`, so they were drawn on the wrong side:
inside the chip in base styles and Aura, over the neighbour chip in
Lumo. The remove button was nudged with a physical `translate` and
overlapped the label.
- Replaced `left` with `inset-inline-start` for the `::before` and
`::after` lines of the overflow chip in base styles and Lumo
- Replaced `border-left` with `border-inline-start` in the Lumo chip
styles
- Mirrored the remove button `translate` in RTL in the base chip styles
- Added a visual test with an overflow chip in RTL for base styles, Lumo
and Aura
- LTR baselines are unchanged
## Type of change
- Bugfix
## How to test
1. Open `dev/multi-select-combo-box.html` and set `dir="rtl"` on
`<html>`
2. Select enough items for the overflow chip to show with a count of 3
or more
3. The stacked lines appear on the right side of the overflow chip, in
the gap before the field edge, and the remove button has a gap to the
label
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>1 parent 8449a65 commit 28016d3
9 files changed
Lines changed: 68 additions & 5 deletions
File tree
- packages
- multi-select-combo-box
- src/styles
- test/visual
- aura
- screenshots
- dark/multi-select-combo-box/baseline
- default/multi-select-combo-box/baseline
- base
- screenshots/multi-select-combo-box/baseline
- lumo
- screenshots/multi-select-combo-box/baseline
- vaadin-lumo-styles/src/components
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
55 | 59 | | |
56 | 60 | | |
57 | 61 | | |
| |||
90 | 94 | | |
91 | 95 | | |
92 | 96 | | |
93 | | - | |
| 97 | + | |
94 | 98 | | |
95 | 99 | | |
96 | 100 | | |
97 | | - | |
| 101 | + | |
98 | 102 | | |
99 | 103 | | |
100 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
73 | 92 | | |
74 | 93 | | |
75 | 94 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
110 | 130 | | |
111 | 131 | | |
112 | 132 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
131 | 151 | | |
132 | 152 | | |
133 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
| |||
0 commit comments