|
1 | 1 | import { expect } from '@esm-bundle/chai'; |
2 | 2 | import { aTimeout, fixtureSync, nextFrame } from '@vaadin/testing-helpers'; |
3 | 3 | import sinon from 'sinon'; |
4 | | -import '../vaadin-grid.js'; |
| 4 | +import '../all-imports.js'; |
5 | 5 | import { html, PolymerElement } from '@polymer/polymer/polymer-element.js'; |
6 | 6 | import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js'; |
7 | 7 | import { |
8 | 8 | flushGrid, |
| 9 | + getBodyCellContent, |
9 | 10 | getCellContent, |
10 | 11 | getContainerCell, |
11 | 12 | getFirstCell, |
@@ -204,6 +205,10 @@ describe('data provider', () => { |
204 | 205 | expect(page).to.be.above(-1); |
205 | 206 | } |
206 | 207 | }); |
| 208 | + |
| 209 | + it('should set itemHasChildren path by default', () => { |
| 210 | + expect(grid.itemHasChildrenPath).to.equal('children'); |
| 211 | + }); |
207 | 212 | }); |
208 | 213 |
|
209 | 214 | describe('tree', () => { |
@@ -247,16 +252,16 @@ describe('data provider', () => { |
247 | 252 | } |
248 | 253 |
|
249 | 254 | beforeEach(() => { |
| 255 | + const treeColumn = document.createElement('vaadin-grid-tree-column'); |
| 256 | + treeColumn.path = 'value'; |
| 257 | + grid.itemHasChildrenPath = 'value'; |
| 258 | + grid.prepend(treeColumn); |
250 | 259 | grid.pageSize = 5; |
251 | 260 | grid.dataProvider = sinon.spy(finiteDataProvider); |
252 | 261 | generateItemIds = false; |
253 | 262 | }); |
254 | 263 |
|
255 | 264 | describe('first level', () => { |
256 | | - it('should set itemHasChildren path by default', () => { |
257 | | - expect(grid.itemHasChildrenPath).to.equal('children'); |
258 | | - }); |
259 | | - |
260 | 265 | it('should have collapsed items by default', () => { |
261 | 266 | for (let i = 0; i < grid._effectiveSize; i++) { |
262 | 267 | expect(isIndexExpanded(grid, i)).to.be.false; |
@@ -455,7 +460,7 @@ describe('data provider', () => { |
455 | 460 | finiteDataProvider(params, callback); |
456 | 461 | // Only the root-level items (10) should be rendered at this point even though the |
457 | 462 | // data request for the first expanded item resolved |
458 | | - expect(grid._effectiveSize).to.equal(10); |
| 463 | + expect(getBodyCellContent(grid, 1, 0).textContent).to.equal('foo1'); |
459 | 464 | done(); |
460 | 465 | }, 0); |
461 | 466 | } |
@@ -557,6 +562,62 @@ describe('data provider', () => { |
557 | 562 | expect(grid._cache.getItemForIndex(18)).to.deep.equal({ level: 0, value: 'foo8' }); |
558 | 563 | }); |
559 | 564 | }); |
| 565 | + |
| 566 | + describe('rendering', () => { |
| 567 | + function getFirstRowUpdateCount() { |
| 568 | + const callsForFirstIndex = grid._updateItem.getCalls().filter((call) => { |
| 569 | + const item = call.args[1]; |
| 570 | + return item.value === '0'; |
| 571 | + }); |
| 572 | + return callsForFirstIndex.length; |
| 573 | + } |
| 574 | + |
| 575 | + beforeEach(async () => { |
| 576 | + grid.itemIdPath = 'value'; |
| 577 | + grid.dataProvider = ({ parentItem, page, pageSize }, cb) => { |
| 578 | + const pageItems = [...Array(3)].map((_, i) => { |
| 579 | + const indexInLevel = page * pageSize + i; |
| 580 | + return { |
| 581 | + value: `${parentItem ? `${parentItem.value}-` : ''}${indexInLevel}`, |
| 582 | + }; |
| 583 | + }); |
| 584 | + |
| 585 | + cb(pageItems, 3); |
| 586 | + }; |
| 587 | + sinon.spy(grid, '_updateItem'); |
| 588 | + await nextFrame(); |
| 589 | + }); |
| 590 | + |
| 591 | + it('should limit row updates', async () => { |
| 592 | + grid.expandedItems = [{ value: '0' }, { value: '1' }, { value: '1-0' }, { value: '2' }]; |
| 593 | + await nextFrame(); |
| 594 | + // There are currently two _updateItem calls for a row. The extra one (a direct update request) |
| 595 | + // is coming from _expandedItemsChanged. |
| 596 | + expect(getFirstRowUpdateCount()).to.equal(2); |
| 597 | + }); |
| 598 | + |
| 599 | + it('should limit row updates on a small size', async () => { |
| 600 | + grid.size = 3; |
| 601 | + grid.expandedItems = [{ value: '0' }, { value: '1' }, { value: '1-0' }, { value: '2' }]; |
| 602 | + await nextFrame(); |
| 603 | + expect(getFirstRowUpdateCount()).to.equal(2); |
| 604 | + }); |
| 605 | + |
| 606 | + it('should limit row updates on a small page size', async () => { |
| 607 | + grid.pageSize = 1; |
| 608 | + grid.expandedItems = [{ value: '0' }, { value: '1' }, { value: '1-0' }, { value: '2' }]; |
| 609 | + await nextFrame(); |
| 610 | + // Changing page size causes yet an additional update request |
| 611 | + expect(getFirstRowUpdateCount()).to.equal(3); |
| 612 | + }); |
| 613 | + |
| 614 | + it('should limit row updates on a small page size, reverse property update order', async () => { |
| 615 | + grid.expandedItems = [{ value: '0' }, { value: '1' }, { value: '1-0' }, { value: '2' }]; |
| 616 | + grid.pageSize = 1; |
| 617 | + await nextFrame(); |
| 618 | + expect(getFirstRowUpdateCount()).to.equal(3); |
| 619 | + }); |
| 620 | + }); |
560 | 621 | }); |
561 | 622 | }); |
562 | 623 |
|
|
0 commit comments