Skip to content

Commit 34d1a35

Browse files
authored
fix: add missing mixin class the MenuBar type (#8737)
1 parent 54fac2a commit 34d1a35

2 files changed

Lines changed: 6 additions & 0 deletions

File tree

‎packages/menu-bar/test/typings/menu-bar.types.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import type { DirMixinClass } from '@vaadin/component-base/src/dir-mixin.js';
66
import type { ResizeMixinClass } from '@vaadin/component-base/src/resize-mixin.js';
77
import type { ItemMixinClass } from '@vaadin/item/src/vaadin-item-mixin.js';
88
import type { ThemableMixinClass } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
9+
import type { ThemePropertyMixinClass } from '@vaadin/vaadin-themable-mixin/vaadin-theme-property-mixin.js';
910
import type { MenuBarItem } from '../../src/vaadin-menu-bar-item.js';
1011
import type { MenuBarListBox } from '../../src/vaadin-menu-bar-list-box.js';
1112
import type { MenuBarMixinClass } from '../../src/vaadin-menu-bar-mixin.js';
@@ -24,6 +25,8 @@ assertType<ResizeMixinClass>(menu);
2425
assertType<ControllerMixinClass>(menu);
2526
assertType<FocusMixinClass>(menu);
2627
assertType<MenuBarMixinClass>(menu);
28+
assertType<ThemableMixinClass>(menu);
29+
assertType<ThemePropertyMixinClass>(menu);
2730

2831
menu.addEventListener('item-selected', (event) => {
2932
assertType<MenuBarItemSelectedEvent>(event);

‎packages/vaadin-themable-mixin/vaadin-themable-mixin.d.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ export declare class ThemableMixinClass {
2020
protected static finalizeStyles(styles?: CSSResultGroup): CSSResult[];
2121
}
2222

23+
// eslint-disable-next-line @typescript-eslint/no-empty-object-type
24+
export declare interface ThemableMixinClass extends ThemePropertyMixinClass {}
25+
2326
/**
2427
* Registers CSS styles for a component type. Make sure to register the styles before
2528
* the first instance of a component of the type is attached to DOM.

0 commit comments

Comments
 (0)