Skip to content

Commit 4505851

Browse files
authored
test: refactor select unit tests to not use Lumo entrypoints (#8959)
1 parent 45ab64d commit 4505851

5 files changed

Lines changed: 21 additions & 8 deletions

File tree

‎packages/select/test/accessibility.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { sendKeys } from '@vaadin/test-runner-commands';
33
import { fixtureSync, nextRender, nextUpdate } from '@vaadin/testing-helpers';
44
import './not-animated-styles.js';
55
import '../src/vaadin-select.js';
6-
import '@vaadin/item/vaadin-item.js';
7-
import '@vaadin/list-box/vaadin-list-box.js';
6+
import '@vaadin/item/src/vaadin-item.js';
7+
import '@vaadin/list-box/src/vaadin-list-box.js';
88

99
describe('accessibility', () => {
1010
let select, valueButton;

‎packages/select/test/renderer.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import { fixtureSync, nextRender, nextUpdate } from '@vaadin/testing-helpers';
33
import sinon from 'sinon';
44
import './not-animated-styles.js';
55
import '../src/vaadin-select.js';
6-
import '@vaadin/item/vaadin-item.js';
7-
import '@vaadin/list-box/vaadin-list-box.js';
6+
import '@vaadin/item/src/vaadin-item.js';
7+
import '@vaadin/list-box/src/vaadin-list-box.js';
88

99
describe('renderer', () => {
1010
let select;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
2+
3+
// TODO: subset of Lumo needed for unit tests to pass.
4+
// These should be eventually covered by base styles.
5+
registerStyles(
6+
'vaadin-item',
7+
css`
8+
:host {
9+
display: flex;
10+
}
11+
`,
12+
);

‎packages/select/test/select.test.js‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@ import {
1414
} from '@vaadin/testing-helpers';
1515
import sinon from 'sinon';
1616
import './not-animated-styles.js';
17+
import './select-test-styles.test.js';
1718
import '../src/vaadin-select.js';
18-
import '@vaadin/item/vaadin-item.js';
19-
import '@vaadin/list-box/vaadin-list-box.js';
19+
import '@vaadin/item/src/vaadin-item.js';
20+
import '@vaadin/list-box/src/vaadin-list-box.js';
2021
import { html, render } from 'lit';
2122

2223
describe('vaadin-select', () => {

‎packages/select/test/validation.test.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import { fixtureSync, nextRender, nextUpdate, outsideClick } from '@vaadin/testi
44
import sinon from 'sinon';
55
import './not-animated-styles.js';
66
import '../src/vaadin-select.js';
7-
import '@vaadin/item/vaadin-item.js';
8-
import '@vaadin/list-box/vaadin-list-box.js';
7+
import '@vaadin/item/src/vaadin-item.js';
8+
import '@vaadin/list-box/src/vaadin-list-box.js';
99

1010
describe('validation', () => {
1111
let select, validateSpy, valueChangedSpy, changeSpy;

0 commit comments

Comments
 (0)