Skip to content

Commit 465b17f

Browse files
authored
test: replace some unit tests with snapshot tests (#4336)
1 parent 8f5a2a9 commit 465b17f

3 files changed

Lines changed: 143 additions & 123 deletions

File tree

‎packages/date-picker/test/basic.test.js‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -128,12 +128,6 @@ describe('basic features', () => {
128128
expect(event.defaultPrevented).to.be.false;
129129
});
130130

131-
it('should pass the placeholder attribute to the input tag', () => {
132-
const placeholder = 'Pick a date';
133-
datepicker.set('placeholder', placeholder);
134-
expect(input.placeholder).to.be.equal(placeholder);
135-
});
136-
137131
it('should scroll to today by default', async () => {
138132
const overlayContent = getOverlayContent(datepicker);
139133
const spy = sinon.spy(overlayContent, 'scrollToDate');
@@ -244,11 +238,6 @@ describe('basic features', () => {
244238
expect(datepicker.clientWidth).to.equal(width);
245239
});
246240

247-
it('should set has-value attribute when value is set', () => {
248-
datepicker.value = '2000-02-01';
249-
expect(datepicker.hasAttribute('has-value')).to.be.true;
250-
});
251-
252241
describe('fullscreen', () => {
253242
beforeEach(() => {
254243
datepicker._fullscreen = true;

‎packages/date-picker/test/dom/__snapshots__/date-picker.test.snap.js‎

Lines changed: 138 additions & 112 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,37 @@ snapshots["vaadin-date-picker host default"] =
2727
`;
2828
/* end snapshot vaadin-date-picker host default */
2929

30+
snapshots["vaadin-date-picker host disabled"] =
31+
`<vaadin-date-picker
32+
aria-disabled="true"
33+
disabled=""
34+
>
35+
<label
36+
for="input-vaadin-date-picker-3"
37+
id="label-vaadin-date-picker-0"
38+
slot="label"
39+
>
40+
</label>
41+
<div
42+
hidden=""
43+
id="error-message-vaadin-date-picker-2"
44+
slot="error-message"
45+
>
46+
</div>
47+
<input
48+
aria-expanded="false"
49+
aria-haspopup="dialog"
50+
autocomplete="off"
51+
disabled=""
52+
id="input-vaadin-date-picker-3"
53+
role="combobox"
54+
slot="input"
55+
tabindex="-1"
56+
>
57+
</vaadin-date-picker>
58+
`;
59+
/* end snapshot vaadin-date-picker host disabled */
60+
3061
snapshots["vaadin-date-picker host placeholder"] =
3162
`<vaadin-date-picker placeholder="Placeholder">
3263
<label
@@ -54,6 +85,60 @@ snapshots["vaadin-date-picker host placeholder"] =
5485
`;
5586
/* end snapshot vaadin-date-picker host placeholder */
5687

88+
snapshots["vaadin-date-picker host readonly"] =
89+
`<vaadin-date-picker readonly="">
90+
<label
91+
for="input-vaadin-date-picker-3"
92+
id="label-vaadin-date-picker-0"
93+
slot="label"
94+
>
95+
</label>
96+
<div
97+
hidden=""
98+
id="error-message-vaadin-date-picker-2"
99+
slot="error-message"
100+
>
101+
</div>
102+
<input
103+
aria-expanded="false"
104+
aria-haspopup="dialog"
105+
autocomplete="off"
106+
id="input-vaadin-date-picker-3"
107+
readonly=""
108+
role="combobox"
109+
slot="input"
110+
>
111+
</vaadin-date-picker>
112+
`;
113+
/* end snapshot vaadin-date-picker host readonly */
114+
115+
snapshots["vaadin-date-picker host required"] =
116+
`<vaadin-date-picker required="">
117+
<label
118+
for="input-vaadin-date-picker-3"
119+
id="label-vaadin-date-picker-0"
120+
slot="label"
121+
>
122+
</label>
123+
<div
124+
hidden=""
125+
id="error-message-vaadin-date-picker-2"
126+
slot="error-message"
127+
>
128+
</div>
129+
<input
130+
aria-expanded="false"
131+
aria-haspopup="dialog"
132+
autocomplete="off"
133+
id="input-vaadin-date-picker-3"
134+
required=""
135+
role="combobox"
136+
slot="input"
137+
>
138+
</vaadin-date-picker>
139+
`;
140+
/* end snapshot vaadin-date-picker host required */
141+
57142
snapshots["vaadin-date-picker host label"] =
58143
`<vaadin-date-picker has-label="">
59144
<label
@@ -148,6 +233,59 @@ snapshots["vaadin-date-picker host error"] =
148233
`;
149234
/* end snapshot vaadin-date-picker host error */
150235

236+
snapshots["vaadin-date-picker host name"] =
237+
`<vaadin-date-picker name="Field Name">
238+
<label
239+
for="input-vaadin-date-picker-3"
240+
id="label-vaadin-date-picker-0"
241+
slot="label"
242+
>
243+
</label>
244+
<div
245+
hidden=""
246+
id="error-message-vaadin-date-picker-2"
247+
slot="error-message"
248+
>
249+
</div>
250+
<input
251+
aria-expanded="false"
252+
aria-haspopup="dialog"
253+
autocomplete="off"
254+
id="input-vaadin-date-picker-3"
255+
name="Field Name"
256+
role="combobox"
257+
slot="input"
258+
>
259+
</vaadin-date-picker>
260+
`;
261+
/* end snapshot vaadin-date-picker host name */
262+
263+
snapshots["vaadin-date-picker host value"] =
264+
`<vaadin-date-picker has-value="">
265+
<label
266+
for="input-vaadin-date-picker-3"
267+
id="label-vaadin-date-picker-0"
268+
slot="label"
269+
>
270+
</label>
271+
<div
272+
hidden=""
273+
id="error-message-vaadin-date-picker-2"
274+
slot="error-message"
275+
>
276+
</div>
277+
<input
278+
aria-expanded="false"
279+
aria-haspopup="dialog"
280+
autocomplete="off"
281+
id="input-vaadin-date-picker-3"
282+
role="combobox"
283+
slot="input"
284+
>
285+
</vaadin-date-picker>
286+
`;
287+
/* end snapshot vaadin-date-picker host value */
288+
151289
snapshots["vaadin-date-picker shadow default"] =
152290
`<div class="vaadin-date-picker-container">
153291
<div part="label">
@@ -425,115 +563,3 @@ snapshots["vaadin-date-picker shadow theme"] =
425563
`;
426564
/* end snapshot vaadin-date-picker shadow theme */
427565

428-
snapshots["vaadin-date-picker host readonly"] =
429-
`<vaadin-date-picker readonly="">
430-
<label
431-
for="input-vaadin-date-picker-3"
432-
id="label-vaadin-date-picker-0"
433-
slot="label"
434-
>
435-
</label>
436-
<div
437-
hidden=""
438-
id="error-message-vaadin-date-picker-2"
439-
slot="error-message"
440-
>
441-
</div>
442-
<input
443-
aria-expanded="false"
444-
aria-haspopup="dialog"
445-
autocomplete="off"
446-
id="input-vaadin-date-picker-3"
447-
readonly=""
448-
role="combobox"
449-
slot="input"
450-
>
451-
</vaadin-date-picker>
452-
`;
453-
/* end snapshot vaadin-date-picker host readonly */
454-
455-
snapshots["vaadin-date-picker host required"] =
456-
`<vaadin-date-picker required="">
457-
<label
458-
for="input-vaadin-date-picker-3"
459-
id="label-vaadin-date-picker-0"
460-
slot="label"
461-
>
462-
</label>
463-
<div
464-
hidden=""
465-
id="error-message-vaadin-date-picker-2"
466-
slot="error-message"
467-
>
468-
</div>
469-
<input
470-
aria-expanded="false"
471-
aria-haspopup="dialog"
472-
autocomplete="off"
473-
id="input-vaadin-date-picker-3"
474-
required=""
475-
role="combobox"
476-
slot="input"
477-
>
478-
</vaadin-date-picker>
479-
`;
480-
/* end snapshot vaadin-date-picker host required */
481-
482-
snapshots["vaadin-date-picker host name"] =
483-
`<vaadin-date-picker name="Field Name">
484-
<label
485-
for="input-vaadin-date-picker-3"
486-
id="label-vaadin-date-picker-0"
487-
slot="label"
488-
>
489-
</label>
490-
<div
491-
hidden=""
492-
id="error-message-vaadin-date-picker-2"
493-
slot="error-message"
494-
>
495-
</div>
496-
<input
497-
aria-expanded="false"
498-
aria-haspopup="dialog"
499-
autocomplete="off"
500-
id="input-vaadin-date-picker-3"
501-
name="Field Name"
502-
role="combobox"
503-
slot="input"
504-
>
505-
</vaadin-date-picker>
506-
`;
507-
/* end snapshot vaadin-date-picker host name */
508-
509-
snapshots["vaadin-date-picker host disabled"] =
510-
`<vaadin-date-picker
511-
aria-disabled="true"
512-
disabled=""
513-
>
514-
<label
515-
for="input-vaadin-date-picker-3"
516-
id="label-vaadin-date-picker-0"
517-
slot="label"
518-
>
519-
</label>
520-
<div
521-
hidden=""
522-
id="error-message-vaadin-date-picker-2"
523-
slot="error-message"
524-
>
525-
</div>
526-
<input
527-
aria-expanded="false"
528-
aria-haspopup="dialog"
529-
autocomplete="off"
530-
disabled=""
531-
id="input-vaadin-date-picker-3"
532-
role="combobox"
533-
slot="input"
534-
tabindex="-1"
535-
>
536-
</vaadin-date-picker>
537-
`;
538-
/* end snapshot vaadin-date-picker host disabled */
539-

‎packages/date-picker/test/dom/date-picker.test.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,11 @@ describe('vaadin-date-picker', () => {
5757
datePicker.name = 'Field Name';
5858
await expect(datePicker).dom.to.equalSnapshot();
5959
});
60+
61+
it('value', async () => {
62+
datePicker.value = '2000-02-01';
63+
await expect(datePicker).dom.to.equalSnapshot();
64+
});
6065
});
6166

6267
describe('shadow', () => {

0 commit comments

Comments
 (0)